Repository navigation
docs: map the threat model to STRIDE - #442
Merged
Merged
Conversation
Place every threat under its STRIDE categories and cover the three the existing threats covered least. Repudiation lists which privileged calls publish an event and what proves an act once the RPC drops it. Information disclosure says what is public on chain and what stays off it. Two threats come out of it: a shared signing link shows its call before it lands (R13), and the verifier stub lists and delists without an event (R14). The scope moves to the commit the events were checked against. Closes #438
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
15 tasks
Present the threat model in the shape the Audit Bank asks for: a data flow diagram with its trust boundaries, numbered flows, issues for each STRIDE category with their remediations, the Soroban checks and the points the repository cannot confirm. Each issue points to the threat that holds its control and tests instead of restating it. Two risks had no threat of their own and get one: a call made in a holder's name (X14) and the choice of which report prices an epoch (O13).
18 of 19 tasks
Record what the self-service security tools found in the contracts and how each finding was triaged. Scout is the tool of record: its version, command and raw report are committed, and its 28 hits match an earlier run on the tranche2 tag. Almanax, Certora Sunbeam and a check against the Soroban Security Portal add their findings and proofs. No critical, high or medium finding from the scanners is a new bug. The plan covers the three open bugs the sweep found or confirmed.
luchobonatti
approved these changes
Nov 13, 2026
luchobonatti
left a comment
Member
There was a problem hiding this comment.
LGTM. One optional suggestion inline.
| recoveries; and the compliance contract's modules and bindings. Holders' | ||
| requests, cancellations and claims publish events too, and so do the calls | ||
| anyone may make. Three calls succeed without an event because they change | ||
| nothing: granting a role already held, a recovery from an empty balance, and |
Member
There was a problem hiding this comment.
With the kit's verifier recovery_target returns None, so recovery fails with IdentityMismatch before reaching the balance. Maybe scope this to a registry that names a recovery target?
docs: add the STRIDE template and the security scan
This was referenced Nov 13, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #438
The SCF Audit Bank asks for a STRIDE threat model with the application.
docs/THREAT_MODEL.mdlists its threats by area and never names STRIDE. Tampering, denial of service and elevation of privilege were well covered, spoofing only in part, and repudiation and information disclosure not at all. This change places every threat under its STRIDE categories and covers the three thin ones in full.Changes
/signlink shows its call, such as a freeze or a report's price, before the call lands.Deviations
allowpublish an event.f3c03f8to56b22d1, the commit the events were checked against.Acceptance criteria
require_auth, role checks, one signature per account, the console's signing page) and links the threats that test it (R4, R12)Test plan
Automated tests
None: documentation only. A link check over the three changed files passes: every relative link and every anchor resolves, and the table has one row for each of the 39 threat headings.
Manual verification
docs/THREAT_MODEL.mdat the STRIDE section.allowon the identity verifier.Breaking changes
None.
Checklist
Screenshots
None.