Skip to content

docs: restore O13 and number the feed threat O14 - #455

Merged
hpmaxi merged 1 commit into
tranche-3from
docs/threat-model-o14
Nov 13, 2026
Merged

hpmaxi merged 1 commit into
tranche-3from
docs/threat-model-o14

Conversation

@hpmaxi

@hpmaxi hpmaxi commented Nov 13, 2026

Copy link
Copy Markdown
Contributor

Summary

Refs #438, #443, #236

The STRIDE work and the SEP-40 feed each added a threat numbered O13 to docs/THREAT_MODEL.md. When #442 merged into tranche-3, the conflict kept the feed's O13 and dropped STRIDE's ("Choosing which report prices an epoch"). Four links still point at the dropped section, and the feed's threat has no row in the STRIDE table.

Changes

  • STRIDE's O13 is back, word for word, under its original heading, so the links in docs/SECURITY_SCAN.md, docs/STRIDE-threat-model.md and the STRIDE table resolve again.
  • The feed's threat is now O14, and the sentence in O12 that points to it says O14.
  • O14 gets a row in the STRIDE table: spoofing (a copy of the feed bound to another vault answers base() and assets() the same), tampering (the price) and denial of service (base() and assets() fail once the vault's reads trap).
  • The Spoofing, Tampering and Denial of service sections name O14.

Deviations

Acceptance criteria

  • Every O13 link resolves to "Choosing which report prices an epoch"
  • Every threat in the file has a row in the STRIDE table

Test plan

Automated tests

  1. Docs only. npm run format:check: pass.

Manual verification

  1. git show --remerge-diff 6726208 -- docs/THREAT_MODEL.md shows the dropped block; this restores it verbatim from 0e62656.
  2. grep -n "O13\|O14" docs/*.md: each reference names the right threat.

Breaking changes

None.

Checklist

  • Self-reviewed my own diff
  • Tests added or updated
  • Docs updated (if applicable)
  • No unrelated changes bundled in

Screenshots

None.

@vercel

vercel Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
strata-vault-kit-app Ready Ready Preview Nov 13, 2026 3:52pm UTC

Request Review

@hpmaxi
hpmaxi merged commit 268d752 into tranche-3 Nov 13, 2026
10 checks passed

This branch was successfully deployed

1 active deployment
Preview — 55174949 Deployed Nov 13, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant