Repository navigation
docs: restore O13 and number the feed threat O14 - #455
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refs #438, #443, #236
The STRIDE work and the SEP-40 feed each added a threat numbered O13 to
docs/THREAT_MODEL.md. When #442 merged intotranche-3, the conflict kept the feed's O13 and dropped STRIDE's ("Choosing which report prices an epoch"). Four links still point at the dropped section, and the feed's threat has no row in the STRIDE table.Changes
docs/SECURITY_SCAN.md,docs/STRIDE-threat-model.mdand the STRIDE table resolve again.base()andassets()the same), tampering (the price) and denial of service (base()andassets()fail once the vault's reads trap).Deviations
maingets the STRIDE work with that numbering (docs: map the threat model to STRIDE and add the security scan #454);tranche-3matches it.Acceptance criteria
O13link resolves to "Choosing which report prices an epoch"Test plan
Automated tests
npm run format:check: pass.Manual verification
git show --remerge-diff 6726208 -- docs/THREAT_MODEL.mdshows the dropped block; this restores it verbatim from0e62656.grep -n "O13\|O14" docs/*.md: each reference names the right threat.Breaking changes
None.
Checklist
Screenshots
None.