Skip to content

docs: map the threat model to STRIDE and add the security scan - #454

Merged
hpmaxi merged 5 commits into
mainfrom
docs/stride-to-main
Nov 13, 2026
Merged

hpmaxi merged 5 commits into
mainfrom
docs/stride-to-main

Conversation

@hpmaxi

@hpmaxi hpmaxi commented Nov 13, 2026

Copy link
Copy Markdown
Contributor

Summary

Closes #438
Closes #443

Brings the STRIDE threat model and the security scan to main. These are the same commits that #442 and #449 merged into tranche-3; they were written against 56b22d1, whose content main already has, so this pull request adds them without changes. Keeping the same commits means tranche-3 will not bring them in a second time when it reaches main.

Changes

  • docs/THREAT_MODEL.md: a table that places every threat under one or more STRIDE categories, and a section per category. New threats R13 (a shared /sign link shows its call before it lands), R14 (the identity verifier stub lists and delists without an event), X14 (a call made in a holder's name) and O13 (who picks the report that prices an epoch).
  • docs/STRIDE-threat-model.md: the STRIDE document in Stellar's template, with a data flow diagram, trust boundaries, numbered flows, the issues per category and their remediations.
  • docs/SECURITY_SCAN.md: every Scout, Almanax, Certora and Security Portal finding with its triage, and a remediation plan; Scout's raw report committed as evidence.
  • The README and the design document say the threat model follows STRIDE and link both documents.

Deviations

  • The scope is 56b22d1, the commit the events and the scan were checked against. The SEP-40 feed is not on main, so it is not in this threat model.

Acceptance criteria

See #442 and #449, where each criterion was checked.

Test plan

Automated tests

  1. Docs only. CI's checks pass.

Manual verification

  1. git diff 56b22d1 origin/main is empty, so the three commits apply to main exactly as they did to their original base.

Breaking changes

None.

Checklist

  • Self-reviewed my own diff
  • Tests added or updated
  • Docs updated (if applicable)
  • No unrelated changes bundled in

Screenshots

None.

hpmaxi and others added 4 commits November 11, 2026 15:07
Place every threat under its STRIDE categories and cover the three the
existing threats covered least. Repudiation lists which privileged calls
publish an event and what proves an act once the RPC drops it.
Information disclosure says what is public on chain and what stays off
it.

Two threats come out of it: a shared signing link shows its call before
it lands (R13), and the verifier stub lists and delists without an event
(R14). The scope moves to the commit the events were checked against.

Closes #438
Present the threat model in the shape the Audit Bank asks for: a data
flow diagram with its trust boundaries, numbered flows, issues for each
STRIDE category with their remediations, the Soroban checks and the
points the repository cannot confirm. Each issue points to the threat
that holds its control and tests instead of restating it.

Two risks had no threat of their own and get one: a call made in a
holder's name (X14) and the choice of which report prices an epoch
(O13).
Record what the self-service security tools found in the contracts and
how each finding was triaged. Scout is the tool of record: its version,
command and raw report are committed, and its 28 hits match an earlier
run on the tranche2 tag. Almanax, Certora Sunbeam and a check against
the Soroban Security Portal add their findings and proofs.

No critical, high or medium finding from the scanners is a new bug. The
plan covers the three open bugs the sweep found or confirmed.
docs: add the STRIDE template and the security scan
@vercel

vercel Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
strata-vault-kit-app Ready Ready Preview Nov 13, 2026 5:11pm UTC

Request Review

@hpmaxi
hpmaxi merged commit 49cca0a into main Nov 13, 2026
18 checks passed

This branch was successfully deployed

1 active deployment
Preview — 213dfc45 Deployed Nov 13, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants