Repository navigation
docs: map the threat model to STRIDE and add the security scan - #454
Merged
Merged
Conversation
Place every threat under its STRIDE categories and cover the three the existing threats covered least. Repudiation lists which privileged calls publish an event and what proves an act once the RPC drops it. Information disclosure says what is public on chain and what stays off it. Two threats come out of it: a shared signing link shows its call before it lands (R13), and the verifier stub lists and delists without an event (R14). The scope moves to the commit the events were checked against. Closes #438
Present the threat model in the shape the Audit Bank asks for: a data flow diagram with its trust boundaries, numbered flows, issues for each STRIDE category with their remediations, the Soroban checks and the points the repository cannot confirm. Each issue points to the threat that holds its control and tests instead of restating it. Two risks had no threat of their own and get one: a call made in a holder's name (X14) and the choice of which report prices an epoch (O13).
Record what the self-service security tools found in the contracts and how each finding was triaged. Scout is the tool of record: its version, command and raw report are committed, and its 28 hits match an earlier run on the tranche2 tag. Almanax, Certora Sunbeam and a check against the Soroban Security Portal add their findings and proofs. No critical, high or medium finding from the scanners is a new bug. The plan covers the three open bugs the sweep found or confirmed.
docs: add the STRIDE template and the security scan
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
6 tasks done
luchobonatti
approved these changes
Nov 13, 2026
5 tasks done
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #438
Closes #443
Brings the STRIDE threat model and the security scan to
main. These are the same commits that #442 and #449 merged intotranche-3; they were written against56b22d1, whose contentmainalready has, so this pull request adds them without changes. Keeping the same commits meanstranche-3will not bring them in a second time when it reachesmain.Changes
docs/THREAT_MODEL.md: a table that places every threat under one or more STRIDE categories, and a section per category. New threats R13 (a shared/signlink shows its call before it lands), R14 (the identity verifier stub lists and delists without an event), X14 (a call made in a holder's name) and O13 (who picks the report that prices an epoch).docs/STRIDE-threat-model.md: the STRIDE document in Stellar's template, with a data flow diagram, trust boundaries, numbered flows, the issues per category and their remediations.docs/SECURITY_SCAN.md: every Scout, Almanax, Certora and Security Portal finding with its triage, and a remediation plan; Scout's raw report committed as evidence.Deviations
56b22d1, the commit the events and the scan were checked against. The SEP-40 feed is not onmain, so it is not in this threat model.Acceptance criteria
See #442 and #449, where each criterion was checked.
Test plan
Automated tests
Manual verification
git diff 56b22d1 origin/mainis empty, so the three commits apply tomainexactly as they did to their original base.Breaking changes
None.
Checklist
Screenshots
None.