Repository navigation
docs: add the STRIDE template and the security scan - #449
Conversation
Present the threat model in the shape the Audit Bank asks for: a data flow diagram with its trust boundaries, numbered flows, issues for each STRIDE category with their remediations, the Soroban checks and the points the repository cannot confirm. Each issue points to the threat that holds its control and tests instead of restating it. Two risks had no threat of their own and get one: a call made in a holder's name (X14) and the choice of which report prices an epoch (O13).
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Record what the self-service security tools found in the contracts and how each finding was triaged. Scout is the tool of record: its version, command and raw report are committed, and its 28 hits match an earlier run on the tranche2 tag. Almanax, Certora Sunbeam and a check against the Soroban Security Portal add their findings and proofs. No critical, high or medium finding from the scanners is a new bug. The plan covers the three open bugs the sweep found or confirmed.
2310825 to
24eeeeb
Compare
luchobonatti
left a comment
There was a problem hiding this comment.
Looks good overall. A few suggestions inline.
| `main`. [`command.txt`](./evidence/scout/command.txt) has every step. | ||
| - **Raw report.** [`scout-report.json`](./evidence/scout/scout-report.json), | ||
| [`scout-report.md`](./evidence/scout/scout-report.md) and the console output | ||
| [`scout-console.log`](./evidence/scout/scout-console.log). The summary list at |
There was a problem hiding this comment.
scout-console.log doesn't seem to be in the PR (also command.txt:90). Maybe commit it or drop both references?
| The [Soroban Security Portal](https://sorobansecurity.com) is a public database of | ||
| vulnerabilities found in audits of other Stellar projects, not a scanner. Of | ||
| its 954 published vulnerabilities, the 340 rated critical, high or medium were | ||
| grouped into 16 kinds, and each kind was checked against Strata. |
There was a problem hiding this comment.
The table has 17 rows; P0A (#445) is our own finding rather than a Portal entry. Maybe move it to a separate manual-review line?
| | Item | Severity | Fix | Who | Tracked in | By | | ||
| | --- | --- | --- | --- | --- | --- | | ||
| | A zero-share deposit refund blocked by cash dust | Medium | Release the dust so the refund pays, in the same change as the next row | Strata team (BootNode) | [#434](https://github.com/BootNodeDev/strata-vault-kit/issues/434) | Before the audit starts | | ||
| | A zero-asset redemption from a delisted holder stays stuck (P0A) | Low | Let the request settle when the holder cannot receive its shares, for example by burning them as a wind-down claim does, so the epoch reconciles | Strata team (BootNode) | [#445](https://github.com/BootNodeDev/strata-vault-kit/issues/445) | With #434 | |
There was a problem hiding this comment.
#445 is priority: medium on the issue. Maybe align both here and in the Portal table?
|
|
||
| | Item | Severity | Fix | Who | Tracked in | By | | ||
| | --- | --- | --- | --- | --- | --- | | ||
| | A zero-share deposit refund blocked by cash dust | Medium | Release the dust so the refund pays, in the same change as the next row | Strata team (BootNode) | [#434](https://github.com/BootNodeDev/strata-vault-kit/issues/434) | Before the audit starts | |
There was a problem hiding this comment.
#443 asks for a date in this column. Maybe a target date instead of "Before the audit starts"?
| [STRIDE template](https://developers.stellar.org/docs/build/security-docs/threat-modeling/STRIDE-template). | ||
| Each issue below points to the threat in [`THREAT_MODEL.md`](./THREAT_MODEL.md) | ||
| that holds its full control, residual risk and tests, instead of restating | ||
| them. Three issues are about what the whole ledger records or shows rather than |
There was a problem hiding this comment.
Four, maybe? Repudiate.3/.4 and Info.1/.4.
| control in place with a test. The recommended ones are tracked in issues or | ||
| listed as investigation points below. The accepted ones give the reason and | ||
| the risk that remains. | ||
| - **Have additional issues been found after the threat model?** The security |
Summary
Closes #443
The SCF Audit Bank asks for two pieces with the application: a STRIDE threat model, and the results of a self-service security tool with a plan for what stays open. #442 maps the threat model to STRIDE inside
docs/THREAT_MODEL.md, but not in the shape of Stellar's template, and nothing records a scan. This adds both as documents a reviewer can read on their own.Stacked on #442: it builds on that mapping and should merge after it.
Changes
Deviations
56b22d1, whose code equals thetranche2tag, with a git hook for a dependency's branch rename.Acceptance criteria
A. STRIDE in the template's format
docs/STRIDE-threat-model.mdhas the template's four headings, the STRIDE reminders table as written, and answers the five closing questionsSpoof.1,Tamper.1, …), each with its attacker, the step it targets and what it breaksdocs/THREAT_MODEL.mdthat already treats it, instead of restating it; an issue with no threat there becomes a new threat or a follow-up issueSpoof.1.R.1, …) marked In place (with the code or test), Recommended or Accepted (with the reason and the risk that remains)overflow-checksin the release profile, upgrades throughupdate_current_contract_wasm,__constructorand a second init, TTL and archival,require_authon the right addressB. Self-service scan and remediation plan
async-vault,share-token,nav-oracle,compliance,identity-verifier, and the shared crates they use); the raw report is committeddocs/SECURITY_SCAN.mdlists every finding with its severity, its location and its triage: fixed, false positive (with why) or accepted (with why)Test plan
Automated tests
None: documentation only. Checks run on the changed files:
contracts/orcrates/, and every console test title exists in the app's tests.flowchart-v2.scout-report.jsonappears inSECURITY_SCAN.mdwith its file and line.Manual verification
docs/STRIDE-threat-model.mdon the branch: the diagram renders, and each issue links to its threat.docs/SECURITY_SCAN.md: each Scout hit matches a line indocs/evidence/scout/scout-report.md.docs/evidence/scout/command.txt. You should get the same 28 hits from 6 detectors.Breaking changes
None.
Checklist
Screenshots
None.