Repository navigation
refactor(testcerts): correct stale key generation error messages - Maintainability Hunter - #39
Conversation
…intainability Hunter Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Important Review skippedBot user detected. To trigger a single review, invoke the
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #39 +/- ##
=======================================
Coverage 82.11% 82.11%
=======================================
Files 3 3
Lines 218 218
=======================================
Hits 179 179
Misses 21 21
Partials 18 18 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the certificate-generation error-message updates.
No open issues 🎉
What changed in this PR
Corrects stale error messages in the certificate-generation helpers without changing key generation or certificate signing behavior.
Changes:
- Removes the incorrect RSA reference from key-generation errors in both helpers.
- Removes “self-signed” from the CA-signed certificate creation error.
| File | Description |
|---|---|
testcerts.go |
Updates three error strings to accurately describe the failed operations. |
Review effort: Balanced
Co-authored-by: madflojo <1731256+madflojo@users.noreply.github.com>
Error strings in
genSelfSignedKeyPairandgenKeyPairsaid "could not generate rsa key", but the code generates ECDSA P-521 keys.genKeyPairalso said "self-signed certificate" although it signs with the CA. Messages now say "ecdsa key" and "certificate" respectively. No tests assert the old strings; behavior is otherwise unchanged.Validation:
gofmt -l .(clean),go vet ./...,go test ./...all pass.Dedup: open PRs #37 (release) and #38 (tests) checked; no overlap.