Skip to content

refactor(testcerts): correct stale key generation error messages - Maintainability Hunter - #39

Merged
madflojo merged 4 commits into
mainfrom
code-hunters/maintainability-hunter/fix-stale-keygen-errors-2743b1287235868a
Nov 2, 2026
Merged

madflojo merged 4 commits into
mainfrom
code-hunters/maintainability-hunter/fix-stale-keygen-errors-2743b1287235868a

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Error strings in genSelfSignedKeyPair and genKeyPair said "could not generate rsa key", but the code generates ECDSA P-521 keys. genKeyPair also said "self-signed certificate" although it signs with the CA. Messages now say "ecdsa key" and "certificate" respectively. No tests assert the old strings; behavior is otherwise unchanged.

Validation: gofmt -l . (clean), go vet ./..., go test ./... all pass.

Dedup: open PRs #37 (release) and #38 (tests) checked; no overlap.

Generated by Run Maintainability Hunter · auto · 17.8 AIC · ⊞ 11.3K · ◷

…intainability Hunter

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: a2c13fee-6fd3-4e3f-9068-5ae6d9388cdf

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Comment thread testcerts.go Resolved
Comment thread testcerts.go Resolved
@madflojo
madflojo marked this pull request as ready for review November 1, 2026 22:37
Copilot AI balanced review requested due to automatic review settings November 1, 2026 22:37
@codecov

codecov Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.11%. Comparing base (3969d36) to head (aba3fd5).

Files with missing lines Patch % Lines
testcerts.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #39   +/-   ##
=======================================
  Coverage   82.11%   82.11%           
=======================================
  Files           3        3           
  Lines         218      218           
=======================================
  Hits          179      179           
  Misses         21       21           
  Partials       18       18           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain for the certificate-generation error-message updates.

No open issues 🎉

What changed in this PR

Corrects stale error messages in the certificate-generation helpers without changing key generation or certificate signing behavior.

Changes:

  • Removes the incorrect RSA reference from key-generation errors in both helpers.
  • Removes “self-signed” from the CA-signed certificate creation error.
File Description
testcerts.go Updates three error strings to accurately describe the failed operations.

Review effort: Balanced

Co-authored-by: madflojo <1731256+madflojo@users.noreply.github.com>
Copilot AI requested a review from madflojo November 1, 2026 22:42
@madflojo
madflojo requested a balanced review from Copilot November 2, 2026 13:33

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain for the error-message corrections and lint workflow Go setup.

No open issues 🎉

Review effort: Balanced

@madflojo
madflojo merged commit 535985f into main Nov 2, 2026
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants