Repository navigation
docs(testcerts): document GenerateCerts CA vs leaf output - Documentation Hunter - #40
Open
github-actions[bot] wants to merge 1 commit into
Conversation
…tion Hunter Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Important Review skippedBot user detected. To trigger a single review, invoke the
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GenerateCertsreturned very different certificates depending on whether domains are passed, but its doc comment didn't say so. Now documented (fromgencerts.go): with no domains it returns the self-signed CA certificate/key (no SANs, kept for backwards compatibility); with domains it returns a leaf certificate signed by a freshly generated CA, which is not returned.Validation:
gofmt -l .clean,go vet ./...,go test ./...pass.Dedup: open PRs #37, #38, #39 checked; none touch
gencerts.go.