Skip to content

refactor(testcerts): correct stale key generation error messages - Maintainability Hunter #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
madflojo merged 4 commits into from
Nov 2, 2026
Merged

refactor(testcerts): correct stale key generation error messages - Maintainability Hunter #39

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
803bbae
refactor(testcerts): correct stale key generation error messages - Ma…
github-actions[bot] Oct 28, 2026
ef83347
Apply suggestion from @madflojo
madflojo Nov 1, 2026
c33591e
Apply suggestion from @madflojo
madflojo Nov 1, 2026
aba3fd5
Pin Go toolchain for golangci-lint
Copilot Nov 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions testcerts.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,7 +418,7 @@ func genSelfSignedKeyPair(cert *x509.Certificate) (*pem.Block, *ecdsa.PrivateKey
// Create a Private Key
key, err := ecdsa.GenerateKey(elliptic.P521(), rand.Reader)
if err != nil {
return nil, nil, fmt.Errorf("could not generate rsa key - %w", err)
return nil, nil, fmt.Errorf("could not generate key - %w", err)
}

// Use CA Cert to sign and create a Public Cert
Expand All @@ -438,12 +438,12 @@ func genKeyPair(
// Create a Private Key
key, err := ecdsa.GenerateKey(elliptic.P521(), rand.Reader)
if err != nil {
return nil, nil, fmt.Errorf("could not generate rsa key - %w", err)
return nil, nil, fmt.Errorf("could not generate key - %w", err)
}

signedCert, err := x509.CreateCertificate(rand.Reader, cert, ca, &key.PublicKey, caKey)
if err != nil {
return nil, nil, fmt.Errorf("could not generate self-signed certificate - %w", err)
return nil, nil, fmt.Errorf("could not generate certificate - %w", err)
}
return certToPemBlock(signedCert), key, nil
}
Expand Down
Loading