Repository navigation
feat(mf): support layered container exposes - #14912
ScriptedAlchemy wants to merge 80 commits into
Conversation
Merging this PR will not alter performance
Comparing Footnotes
|
9d29773 to
5ffeb7a
Compare
📦 Binary Size-limit
Note This PR is stacked on ❌ Size increased by 56.13KB from 67.74MB to 67.80MB (⬆️0.08%) |
Rsdoctor Bundle Diff AnalysisFound 5 projects in monorepo, 0 projects with changes. 📊 Quick Summary
Generated by Rsdoctor GitHub Action |
5ffeb7a to
684b404
Compare
684b404 to
c4d3c04
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c4d3c0444e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…to codex/work-pr14912
Deploying rspack with
|
| Latest commit: |
1162106
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ae1a8f02.rspack-v2.pages.dev |
| Branch Preview URL: | https://codex-mf-layered-container-e.rspack-v2.pages.dev |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b3a3fedc2e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7ee51282af
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6c1af2cc11
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
# Conflicts: # crates/rspack_plugin_mf/src/sharing/shared_used_exports_optimizer_plugin.rs
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b21cf1d6ee
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…tainer-exposes # Conflicts: # crates/rspack_plugin_mf/src/container/container_entry_module.rs
Replace the parallel expose_layers vector, its constructors, and the ExposeIdentifierPayload mirror with an optional layer field on ExposeOptions, serialized only when present so unlayered container identifiers keep webpack's [[key, options]] payload. Follows ProvideOptions::layer.
…ures Validate exposes.layer where the option is introduced, drop the empty-layer expose from the option fixture and docs, and remove experiments.outputModule from the ported layers-full fixtures, which already set output.module.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a47cc845f2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Apply the upstream optional-name contract to enhanced base options and cover consumer-only constructors.
Motivation
Expose the same source in different layers without requiring users to assign each variant through
module.rules.Changes
Add
exposes.*.layerto enhanced containers and carry the configured layer through bindings, dependencies, and module builds:Omitting
layerleaves it unspecified. Legacy expose configurations retain their behavior. The final stack adds nonempty-name validation in #14913.Direct expose tests cover server/client and omitted layers in both runtime modes. Type tests check the enhanced API boundary; serial fixtures cover layered remote loading.
Stack 3/4: #12977 → #14911 → #14912 → #14913.
Enhanced Webpack parity and layer-aware federation RFC.