Repository navigation
feat(mf): initialize ordered share scopes at runtime - #14911
ScriptedAlchemy wants to merge 75 commits into
Conversation
ScriptedAlchemy
changed the title
Merging this PR will not alter performance
Comparing 
Footnotes
|
4cd8f5c to
cbc7d41
Compare
📦 Binary Size-limit
Note This PR is stacked on ❌ Size increased by 52.13KB from 67.74MB to 67.79MB (⬆️0.08%) |
Rsdoctor Bundle Diff AnalysisFound 5 projects in monorepo, 0 projects with changes. 📊 Quick Summary
Generated by Rsdoctor GitHub Action |
cbc7d41 to
d219e27
Compare
d219e27 to
804192f
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 804192f168
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…pr14911 # Conflicts: # crates/rspack_plugin_mf/src/container/embed_federation_runtime_module.rs
Deploying rspack with
|
| Latest commit: |
27789f6
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://869527d3.rspack-v2.pages.dev |
| Branch Preview URL: | https://codex-mf-share-scope-runtime.rspack-v2.pages.dev |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2a348f967f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
# Conflicts: # packages/rspack/src/runtime/moduleFederationDefaultRuntime.js
# Conflicts: # packages/rspack/src/runtime/moduleFederationDefaultRuntime.js
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 72c9492ee4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 258fcbb9e0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a7c7947218
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Also drop an #[inline(always)] on the shared exports optimizer that a later PR in the stack removed anyway.
…tputModule, and document ordered-scope startup
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2150ebc17f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Preserve container name validation alongside ordered share scope normalization.
Summary
Initialize ordered share scopes before their shared consumers run.
loaded-first.Coverage
Runtime and config cases cover scope binding, ordered initial and async consumes, eager startup, shared runtimes, and legacy container initialization.
Related links
Stack 2/4: #12977 → #14911 → #14912 → #14913.
Checklist