Skip to content

VAY-1060: Expose manifest-bound Finance publication snapshot - #862

Merged
FlamurMaliqi merged 1 commit into
mainfrom
flamurmaliqi2811/vay-1060-finance-publication-snapshot
Aug 15, 2026
Merged

FlamurMaliqi merged 1 commit into
mainfrom
flamurmaliqi2811/vay-1060-finance-publication-snapshot

Conversation

@FlamurMaliqi

Copy link
Copy Markdown
Collaborator

Summary

  • add a Finance-owned booking-publication-owner-snapshot.v1 adapter
  • bind public payment content to the exact accepted Finance payment-method revision
  • expose only selected, available, genuinely ready public methods with current committed currency
  • fail closed for missing, stale, mismatched, or unavailable Finance evidence

Stack

Depends on #860. This slice intentionally remains uncomposed until all four owner adapters exist.

Verification

  • focused unit tests: 2 passed
  • npm --workspace vayada-api run typecheck
  • npm run typecheck
  • git diff --check
  • independent adversarial review: approved, no P1/P2

Changed non-generated lines: 196 (<400).

Linear: VAY-1060

@coderabbitai

coderabbitai Bot commented Aug 13, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 38 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 4e945bef-8474-4988-9603-fcadefec28d1

📥 Commits

Reviewing files that changed from the base of the PR and between 49fe0cb and c7ebce2.

📒 Files selected for processing (2)
  • apps/api/src/domains/financeBookingPublicationSnapshot.ts
  • apps/api/src/financeBookingPublicationSnapshot.test.ts

Comment @coderabbitai help to get the list of available commands.

@FlamurMaliqi
FlamurMaliqi force-pushed the flamurmaliqi2811/vay-1060-persist-built-publication branch from a6dc5cf to 296e4a7 Compare August 15, 2026 09:42
@FlamurMaliqi
FlamurMaliqi force-pushed the flamurmaliqi2811/vay-1060-finance-publication-snapshot branch from 109a233 to 2973cb1 Compare August 15, 2026 09:43
@FlamurMaliqi
FlamurMaliqi marked this pull request as ready for review August 15, 2026 10:30
@FlamurMaliqi
FlamurMaliqi force-pushed the flamurmaliqi2811/vay-1060-finance-publication-snapshot branch from 2973cb1 to 388d6f3 Compare August 15, 2026 10:32
@FlamurMaliqi
FlamurMaliqi force-pushed the flamurmaliqi2811/vay-1060-persist-built-publication branch 3 times, most recently from 6ca40cb to c1a9b75 Compare August 15, 2026 10:52
@FlamurMaliqi
FlamurMaliqi force-pushed the flamurmaliqi2811/vay-1060-finance-publication-snapshot branch from 388d6f3 to 4a7661f Compare August 15, 2026 10:59
@FlamurMaliqi
FlamurMaliqi force-pushed the flamurmaliqi2811/vay-1060-persist-built-publication branch from c1a9b75 to ec0918f Compare August 15, 2026 11:00
Base automatically changed from flamurmaliqi2811/vay-1060-persist-built-publication to main August 15, 2026 11:08
@FlamurMaliqi
FlamurMaliqi force-pushed the flamurmaliqi2811/vay-1060-finance-publication-snapshot branch from 4a7661f to c7ebce2 Compare August 15, 2026 11:08
@FlamurMaliqi
FlamurMaliqi merged commit e759c55 into main Aug 15, 2026
11 checks passed
@FlamurMaliqi
FlamurMaliqi deleted the flamurmaliqi2811/vay-1060-finance-publication-snapshot branch August 15, 2026 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant