Skip to content

VAY-1060: Strictly parse stored public Booking profiles - #864

Merged
FlamurMaliqi merged 1 commit into
mainfrom
flamurmaliqi2811/vay-1060-parse-public-bookability
Aug 15, 2026
Merged

FlamurMaliqi merged 1 commit into
mainfrom
flamurmaliqi2811/vay-1060-parse-public-bookability

Conversation

@FlamurMaliqi

Copy link
Copy Markdown
Collaborator

Summary

  • add an exact, allowlisting runtime parser for stored public-bookability.v1 profiles
  • validate nested types, enums, source/freshness evidence, URLs, public contacts, and readiness invariants
  • return a detached deeply frozen profile and fail closed for poisoned or semantically inconsistent JSON

Stack

Verification

  • npm --workspace @vayada/domain-distribution run test (78 tests)
  • npm --workspace @vayada/domain-distribution run typecheck
  • npm run typecheck
  • focused parser suite: 19 tests, including poisoned nested values and impossible timestamps
  • independent adversarial review: approved, no P1/P2 findings

Scope

Target TypeScript stack only. No legacy changes and no runtime source activation in this PR.

@coderabbitai

coderabbitai Bot commented Aug 13, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 31 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 33b382bc-fc9c-44dc-aa57-d7aa315ffccf

📥 Commits

Reviewing files that changed from the base of the PR and between e759c55 and 6dc9a21.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (3)
  • packages/domain-distribution/package.json
  • packages/domain-distribution/src/publicBookabilityProfileParser.test.ts
  • packages/domain-distribution/src/publicBookabilityProfileParser.ts

Comment @coderabbitai help to get the list of available commands.

@FlamurMaliqi
FlamurMaliqi force-pushed the flamurmaliqi2811/vay-1060-parse-public-bookability branch from 6cd4e51 to 77541c1 Compare August 15, 2026 09:42
@FlamurMaliqi
FlamurMaliqi marked this pull request as ready for review August 15, 2026 10:30
@FlamurMaliqi
FlamurMaliqi force-pushed the flamurmaliqi2811/vay-1060-finance-publication-snapshot branch from 2973cb1 to 388d6f3 Compare August 15, 2026 10:32
@FlamurMaliqi
FlamurMaliqi force-pushed the flamurmaliqi2811/vay-1060-parse-public-bookability branch from 77541c1 to 7da516e Compare August 15, 2026 10:32
@FlamurMaliqi
FlamurMaliqi force-pushed the flamurmaliqi2811/vay-1060-finance-publication-snapshot branch 2 times, most recently from 4a7661f to c7ebce2 Compare August 15, 2026 11:08
Base automatically changed from flamurmaliqi2811/vay-1060-finance-publication-snapshot to main August 15, 2026 11:16
@FlamurMaliqi
FlamurMaliqi force-pushed the flamurmaliqi2811/vay-1060-parse-public-bookability branch from 7da516e to 6dc9a21 Compare August 15, 2026 11:16
@FlamurMaliqi
FlamurMaliqi merged commit cece699 into main Aug 15, 2026
11 checks passed
@FlamurMaliqi
FlamurMaliqi deleted the flamurmaliqi2811/vay-1060-parse-public-bookability branch August 15, 2026 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant