Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,13 +1,40 @@
// Copyright (C) 2026 Intel Corporation
// SPDX-License-Identifier: Apache-2.0

import { screen } from '@testing-library/react';
import { screen, waitFor, within } from '@testing-library/react';
import userEvent from '@testing-library/user-event';
import { getMockedDatasetRevision } from 'mocks/mock-dataset-revision';
import { getMockedQuantizeJob } from 'mocks/mock-job';
import { getMockedModel } from 'mocks/mock-model';
import { getMockedVariant } from 'mocks/mock-model-variant';
import { HttpResponse } from 'msw';
import { render } from 'test-utils/render';

import { $api } from '../../../../api';
import { http } from '../../../../api/utils';
import { server } from '../../../../msw-node-setup';
import { createQueryClient } from '../../../../query-client/query-client';
import { ModelVariantsTabs } from './model-variant-tabs.component';

const trainingRevision = getMockedDatasetRevision({ id: 'training-revision' });
const newerRevision = getMockedDatasetRevision({
id: 'newer-revision',
created_at: '2025-02-01T00:00:00.000000+00:00',
item_counts: { training: 15, validation: 3, testing: 2, total: 20 },
});
const trainedModel = getMockedModel({
training_info: { status: 'successful', dataset_revision_id: trainingRevision.id },
variants: [getMockedVariant({ format: 'openvino', precision: 'fp16' })],
});

const openQuantizationDialog = async (queryClient = createQueryClient()) => {
const user = userEvent.setup();
render(<ModelVariantsTabs model={trainedModel} />, { queryClient });
await user.click(screen.getByRole('button', { name: 'Start quantization' }));

return { user, dialog: within(await screen.findByRole('dialog')) };
};

describe('ModelVariantsTabs', () => {
it('shows a placeholder when the model has no variants', () => {
render(<ModelVariantsTabs model={getMockedModel({ variants: [] })} />);
Expand All @@ -27,4 +54,52 @@ describe('ModelVariantsTabs', () => {
expect(screen.getByRole('button', { name: 'Download model ov-1' })).toBeDisabled();
expect(screen.getByRole('button', { name: 'Start quantization' })).toBeDisabled();
});

it('sizes calibration from the training subset of the model dataset revision', async () => {
const submitJob = rs.fn();
server.use(
http.get('/api/projects/{project_id}/dataset_revisions', () =>
HttpResponse.json([trainingRevision, newerRevision])
),
http.post('/api/jobs', async ({ request }) => {
submitJob(await request.json());
return HttpResponse.json(getMockedQuantizeJob(), { status: 201 });
})
);

const { user, dialog } = await openQuantizationDialog();
const size = dialog.getByRole('textbox', { name: 'Change Max calibration size' });
await waitFor(() => expect(size).toHaveValue(String(trainingRevision.item_counts.training)));

await user.click(dialog.getByRole('checkbox', { name: 'Use full dataset' }));
await user.click(dialog.getByRole('button', { name: 'Start quantization' }));

await waitFor(() =>
expect(submitJob).toHaveBeenCalledWith(
expect.objectContaining({
job_type: 'quantize',
parameters: expect.objectContaining({
model_id: trainedModel.id,
max_calibration_subset_size: trainingRevision.item_counts.training,
}),
})
)
);
});

it.each([
{ state: 'missing', revisions: [newerRevision] },
{ state: 'deleted', revisions: [{ ...trainingRevision, files_deleted: true }, newerRevision] },
])('disables quantization when the training dataset revision is $state', async ({ revisions }) => {
const queryClient = createQueryClient();
const { queryKey } = $api.queryOptions('get', '/api/projects/{project_id}/dataset_revisions', {
params: { path: { project_id: '123' } },
});
queryClient.setQueryData(queryKey, revisions);
server.use(http.get('/api/projects/{project_id}/dataset_revisions', () => HttpResponse.json(revisions)));

const { dialog } = await openQuantizationDialog(queryClient);

expect(dialog.getByRole('button', { name: 'Start quantization' })).toBeDisabled();
});
});
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,13 @@

import { useState } from 'react';

import { $api } from '@/api';
import type { Model } from '@/api/types';
import { toast } from '@/components/toast/toast.component';
import { useTranslation } from '@/i18n';
import { Button, ButtonGroup, Content, Dialog, dimensionValue, Divider, Flex, Heading, Text, View } from '@geti-ui/ui';
import { InfoOutline } from '@geti-ui/ui/icons';
import { useSubmitJob } from 'hooks/api/jobs/jobs.hook';
import { useGetDatasetRevisions } from 'hooks/use-get-dataset-revisions.hook';
import { useProjectIdentifier } from 'hooks/use-project-identifier.hook';

import {
Expand All @@ -19,22 +19,6 @@ import {
MaxNumIterationsField,
} from './quantization-fields.component';

const useDatasetItemsCount = () => {
const project_id = useProjectIdentifier();

const { data: datasetRevisions, isPending } = $api.useQuery('get', '/api/projects/{project_id}/dataset_revisions', {
params: {
path: { project_id },
},
});

// Get the latest dataset revision's total item count
const latestRevision = datasetRevisions?.at(-1);
const totalCount = latestRevision?.item_counts?.total ?? 0;

return { totalCount, isPending };
};

type QuantizationDialogProps = {
model: Model;
onClose: () => void;
Expand All @@ -52,12 +36,16 @@ export const QuantizationDialog = ({ model, onClose }: QuantizationDialogProps)
DEFAULT_QUANTIZATION_PARAMETERS.usesFullCalibrationDataset
);

const { totalCount, isPending: isLoadingCount } = useDatasetItemsCount();
const { data: datasetRevisions, isPending: isLoadingCount } = useGetDatasetRevisions();
const trainingRevision = datasetRevisions?.find(
({ id, files_deleted }) => id === model.training_info.dataset_revision_id && !files_deleted
);
const trainingCount = trainingRevision?.item_counts.training ?? 0;
const submitJob = useSubmitJob();

const maxCalibrationSize = Math.max(totalCount, 1);
const maxCalibrationSize = Math.max(trainingCount, 1);
const effectiveCalibrationSize = Math.min(calibrationSize, maxCalibrationSize);
const hasNoDatasetItems = !isLoadingCount && totalCount === 0;
const hasNoDatasetItems = !isLoadingCount && trainingCount === 0;

const projectId = useProjectIdentifier();

Expand All @@ -72,7 +60,9 @@ export const QuantizationDialog = ({ model, onClose }: QuantizationDialogProps)
model_architecture_id: model.architecture,
max_drop: hasNoMaxAccuracyDrop ? null : accuracyDrop / 100,
max_num_iterations: hasNoMaxAccuracyDrop ? null : maxNumIterations,
max_calibration_subset_size: usesFullCalibrationDataset ? totalCount : effectiveCalibrationSize,
max_calibration_subset_size: usesFullCalibrationDataset
? trainingCount
: effectiveCalibrationSize,
},
},
},
Expand Down
Loading