Skip to content

fix(ui): size calibration from the model training revision - #7963

Open
A-P-S-Bhaidav wants to merge 1 commit into
open-edge-platform:developfrom
A-P-S-Bhaidav:fix/ui/quantization-training-revision
Open

A-P-S-Bhaidav wants to merge 1 commit into
open-edge-platform:developfrom
A-P-S-Bhaidav:fix/ui/quantization-training-revision

Conversation

@A-P-S-Bhaidav

@A-P-S-Bhaidav A-P-S-Bhaidav commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Summary

The quantization dialog limits calibration using the total item count from the last dataset revision returned for the project. The backend loads the selected model's training revision and calibrates on its training split.

Use that revision's training item count for the dialog's limit and the full-dataset request. Disable Start when the model's training dataset revision is missing, deleted, or has no training items.

How to test

Run npm run test:unit -- model-variant-tabs.component.test.tsx from application/ui. The regression uses a model trained on a revision with 70 training items and a newer revision with 20 total items. It verifies the displayed limit, the full-dataset request, and the disabled Start state when the training revision is missing or deleted.

Validation

  • All three new regressions failed on unchanged develop. All 34 model-variant tests passed with the fix.
  • All 1,831 UI unit tests passed without coverage. Formatting, ESLint, TypeScript, import-cycle checks, and the web and desktop UI builds passed.
  • The full coverage run passed 1,827 tests and hit four existing webhook test timeouts on macOS. The isolated webhook file also timed out on unchanged develop. All five webhook tests passed with a 20-second timeout in a local rerun.
  • The regression exercises the dialog and quantization request with mocked API responses. Desktop validation covers the UI asset build.

Checklist

  • The PR title and description are clear and descriptive
  • I have manually tested the changes
  • All changes are covered by automated tests
  • All related issues are linked to this PR (if applicable)
  • Documentation has been updated (if applicable)

Signed-off-by: A-P-S-Bhaidav <apsbhaidav25@kgpian.iitkgp.ac.in>
@A-P-S-Bhaidav
A-P-S-Bhaidav requested a review from a team as a code owner November 16, 2026 18:26
@github-actions github-actions Bot added the Geti UI Issues related to Geti application frontend label Nov 16, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Geti UI Issues related to Geti application frontend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant