Repository navigation
fix(ui): size calibration from the model training revision - #7963
Open
A-P-S-Bhaidav wants to merge 1 commit into
Open
A-P-S-Bhaidav wants to merge 1 commit into
A-P-S-Bhaidav wants to merge 1 commit into
Conversation
Signed-off-by: A-P-S-Bhaidav <apsbhaidav25@kgpian.iitkgp.ac.in>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The quantization dialog limits calibration using the total item count from the last dataset revision returned for the project. The backend loads the selected model's training revision and calibrates on its training split.
Use that revision's training item count for the dialog's limit and the full-dataset request. Disable Start when the model's training dataset revision is missing, deleted, or has no training items.
How to test
Run
npm run test:unit -- model-variant-tabs.component.test.tsxfromapplication/ui. The regression uses a model trained on a revision with 70 training items and a newer revision with 20 total items. It verifies the displayed limit, the full-dataset request, and the disabled Start state when the training revision is missing or deleted.Validation
develop. All 34 model-variant tests passed with the fix.Checklist