Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on holzschu/a-shell#1089.
Native commands selected by
ASHELL_WORKER_COMMANDSrun in a free extension worker through therun_functionhook, without worker-specific code in the command. A full pool or unavailable worker API keeps the existing thread path. The explicitios_posix_spawnAPI admits a worker before returning its PID and supports standard-stream file actions, cwd, wait status and resource usage; an unavailable provider returnsENOTSUP.Detached completion preserves the parent's cwd and session status, and cancellation releases only the child's reservation. The low-level
ios_execv_asyncentry point is included; wiring Dash background syntax to it is a separate change.wc,grep,cksum/sumand the output-open failure ingzipnow preserve caller-owned streams, so successful counting does not become a worker cleanup error.On an iPhone 16 Pro, a three-worker build passed 11
worker-pool-checkcases plus four ios_system spawn/nested-environment cases and the next ordinary command after each, including nested environment, cancellation, capacity, resource usage and PID reuse. Both gzip/wc pipeline gates passed with separate stderr and 2,000,633 output bytes matching the thread path. The same suite passed in the Simulator using released Dash code and a login profile containingalias exit=clear; additional Simulator consumers verified exact output/status and caller-stream lifetime for five wc modes, grep/egrep/fgrep, cksum/sum and gzip's output-open error. Earlier Simulator regressions also cover missing-provider failure, detached cwd/status, interrupted children and thread-start failure.