Repository navigation
Conversation
This was referenced Oct 17, 2026
demrom
marked this pull request as ready for review
October 18, 2026 16:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dash can print a prompt on caller-owned socket streams and then exit without reading a command. This adds opt-in editing with
ASHELL_IOS_SOCKET_INPUT=1and optional embedding callbacks for foreground input, cancellation and resize. Foreground commands receive their original control bytes. The libedit patch and build instructions are included.The update restores the foreground cancellation target and saved interactive mode when a pipeline unwinds, including producer errors after already-started consumers finish. The optional exchange callback receives foreground command IDs without socket opt-in, so an embedding terminal can target Ctrl-C. Prompt Ctrl-C uses Dash's signal handler. Native pipeline consumers receive the same shell variables and command-prefix assignments as direct commands. Unset variables are excluded from child environments, so worker launches receive valid name=value entries.
The public Simulator consumers pass UTF-8 input, foreground EOF, raw input, cancellation, resize and repeated shell reuse, plus pipeline environment and error-unwind regressions. App integration in Simulator passes full-screen TUI startup, two interrupts and recovery in the same shell.
The app stack also requires the separate login-marker fix and holzschu/ios_system#201; the embedding host policy is holzschu/ios_system#204.
On the iPhone, the composed Dash handled SSH prompt arithmetic, pipelines and burst input followed by EOF, and Vim retained raw Ctrl-C before an explicit status-0 quit. The TUI checks used a server-only prompt and skipped the user profile.