Repository navigation
fix(ui): keep a channel row's facepile clear of its pin - #408
Merged
Merged
Conversation
The row's facepile sat under the hover actions at the same spot, so pointing at an avatar hit the pin, which takes presses even before hover since #396, and the facepile faded out on hover. The facepile and actions now share one trailing cluster, facepile first, so neither moves on hover and the pin stays at the row's right edge. Fixes #407 Why: packages/ui/src/components/session-item/session-item.tsx#const TRAILING | the gap between facepile and actions must cover the pin's hit-area spill so a face never pins
This was referenced Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #407
A channel row's facepile was absolutely positioned at the same spot as the row's hover actions. Since #396 the actions take presses without waiting for hover, so pointing at or clicking an avatar hit the invisible pin. On hover the facepile also faded out under the visible pin, which is why its names tooltip never showed on rows (#406).
The facepile and actions now share one trailing cluster at the row's right edge: facepile first, then the actions. Nothing moves on hover, and the pin stays at the right edge where rows without presence show it. The 8px gap equals how far the pin's 40px hit area spills around its 24px button, so the hit area stops at the facepile, and the facepile stacks above it anyway. #396's behavior is unchanged: actions still take a press with no prior hover, and the enlarged hit area still waits for the row's hover. Rows with presence reserve 96px instead of 68px for the cluster, so their titles truncate a little sooner.
Smoke test: a source host (
ACE_HOMEunder/tmp, Tailscale stubbed to exit 1,ACE_DIRECTORYpointed at a localwrangler devofservices/directory) serving this build, plus four scripted teammates in the project's lobby. The host isn't--loopback, because loopback hosts skip lobby subscriptions and would get no presence. In headless Chromium and WebKit, on a row with three people:Built in Ace
No — built with Claude Code outside Ace by an overnight issue watcher, because this Mac's Ace Canary is a participant in the running two-person study (#218); dogfooding gap tracked in #5.