Skip to content

ref(hotkeys): Use TanStack Hotkeys and add devtools #129176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TkDodo merged 10 commits into from
Oct 30, 2026
+435 −896
Merged

ref(hotkeys): Use TanStack Hotkeys and add devtools #129176

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
3694f8e
ref(hotkeys): Use TanStack Hotkeys and add devtools
TkDodo Oct 29, 2026
bb4ab61
ref(hotkeys): Focus adapter tests and fix snapshot ESM loading
TkDodo Oct 29, 2026
5f540a0
ref(hotkeys): Adopt native TanStack shortcut syntax
TkDodo Oct 29, 2026
5d3b176
ref(hotkeys): Remove redundant Seer layout shortcuts
TkDodo Oct 29, 2026
f9aaeb2
Merge branch 'master' into tkdodo/ref/tanstack-hotkeys
TkDodo Oct 29, 2026
02d63c3
ref(hotkeys): Remove unsupported browser zoom workaround
TkDodo Oct 30, 2026
c8f6960
restore alternative key matching for /
TkDodo Oct 30, 2026
495306b
Merge branch 'master' into tkdodo/ref/tanstack-hotkeys
TkDodo Oct 30, 2026
d37d935
bring back azerty zoom
TkDodo Oct 30, 2026
34667ef
Merge remote-tracking branch 'origin/tkdodo/ref/tanstack-hotkeys' int…
TkDodo Oct 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
158 changes: 158 additions & 0 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion static/app/components/commandPalette/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
export const COMMAND_PALETTE_HOTKEYS = ['mod+shift+p', 'mod+k'];
export const COMMAND_PALETTE_HOTKEYS = ['Mod+Shift+P', 'Mod+K'] as const;
12 changes: 6 additions & 6 deletions static/app/components/commandPalette/ui/commandPalette.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -644,7 +644,7 @@ export function CommandPalette({
<Text size="xs" variant="muted">
{t('Ask Seer')}
</Text>
<Hotkey variant="debossed" value="tab" />
<Hotkey variant="debossed" value="Tab" />
</Flex>
) : (
<AnimatePresence mode="popLayout">
Expand Down Expand Up @@ -1207,21 +1207,21 @@ function CommandPaletteHints() {
<Flex align="center" gap="lg">
<Flex align="center" gap="xs">
<Flex align="center" gap="2xs">
<Hotkey variant="debossed" value="up" />
<Hotkey variant="debossed" value="down" />
<Hotkey variant="debossed" value="ArrowUp" />
<Hotkey variant="debossed" value="ArrowDown" />
</Flex>
<Text size="xs" variant="muted">
{t('Move')}
</Text>
</Flex>
<Flex align="center" gap="xs">
<Hotkey variant="debossed" value="enter" />
<Hotkey variant="debossed" value="Enter" />
<Text size="xs" variant="muted">
{t('Select')}
</Text>
</Flex>
<Flex align="center" gap="xs">
<Hotkey variant="debossed" value="shift+enter" />
<Hotkey variant="debossed" value="Shift+Enter" />
<Text size="xs" variant="muted">
{t('New tab')}
</Text>
Expand All @@ -1231,7 +1231,7 @@ function CommandPaletteHints() {
<Text size="xs" variant="muted">
{t('Toggle Command Palette')}
</Text>
<Hotkey variant="debossed" value="mod+k" />
<Hotkey variant="debossed" value="Mod+K" />
</Flex>
</Flex>
</Stack>
Expand Down
12 changes: 6 additions & 6 deletions static/app/components/commandPalette/ui/commandPaletteStateContext.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,10 +198,10 @@ export function CommandPaletteHotkeys() {
// oxlint-disable-next-line react/exhaustive-effect-dependencies
}, [location.pathname, dispatch]);

useHotkeys([
{
match: COMMAND_PALETTE_HOTKEYS,
includeInputs: true,
useHotkeys(
COMMAND_PALETTE_HOTKEYS.map(hotkey => ({
hotkey,
options: {ignoreInputs: false},
callback: () => {
if (!organization) {
return;
Expand All @@ -215,8 +215,8 @@ export function CommandPaletteHotkeys() {
isSeerExplorerEnabled(organization) ? openSeerExplorer : undefined
);
},
},
]);
}))
);

return null;
}
Expand Down
4 changes: 2 additions & 2 deletions static/app/components/core/drawer/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,8 +211,8 @@ export function GlobalDrawer({children}: any) {
// Close the drawer when escape is pressed.
useHotkeys([
{
match: 'Escape',
enabled: isDrawerOpen,
hotkey: 'Escape',
options: {enabled: isDrawerOpen},
callback: () => {
handleClose();
},
Expand Down
Loading
Loading