[TkDodo]

Migrate our manual hotkey implementation to TanStack HotKeys

This removes a ton of wiring we’re doing ourselves now while at the same time, giving us better support for international keyboard layouts.

For example, on a QWERTZ keyboard layout (which I’m using), it’s not possible to open story search because there is no / key. This works now with TanStack HotKeys. There’s also devtools.

[TkDodo]

bugbot run

[cursor]

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit bb4ab61. Configure here.}

[github-actions]

Story previews

Preview the stories changed in this PR on the Vercel deployment:

• app/components/core/drawer/drawer.mdx
• app/components/core/hotkey/hotkey.mdx

_{Preview deployment: https://sentry-ifhsog6fv.sentry.dev}

[priscilawebdev]

On AZERTY keyboards, Cmd++ now matches Mod+/, opening Seer and blocking browser zoom. Should we preserve the previous guard and restore the regression test?

[TkDodo]

not sure which guard or regression test you are referring to? I don’t think this PR removes any behaviour that was there before

[priscilawebdev]

I meant the guard in

sentry/static/packages/scraps/src/hotkey/keyMappings.tsx

Lines 131 to 136 in 4550de1

	// Without shift, a differing ASCII event.key means a different layout
	// maps this physical key to another character (e.g. AZERTY '+' on
	// physical Slash) and we must NOT match.
	if (event.shiftKey) {
	return true;
	}

in this PR, we are also removing this assertion

sentry/static/packages/scraps/src/hotkey/useHotkeys.spec.tsx

Line 365 in 4550de1

it('does not match mod+/ on AZERTY when user presses Cmd++ (physical Slash key)', () => {

[TkDodo]

I will check back if TanStack covers these cases

[TkDodo]

@priscilawebdev thanks for this 🙏

I’ve brought back the possibility to zoom for our french users here:d37d935

But I’ve also reported this upstream because I think (hope) that TanStack HotKeys would handle this for us

[priscilawebdev]

👏