Skip to content

Make ndf into float in edm4eic::Vertex #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
veprbl merged 3 commits into from
Nov 4, 2026
Merged

Make ndf into float in edm4eic::Vertex #182

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3ae9062
Make `ndf` into `float` in `edm4eic::Vertex`
veprbl Oct 19, 2026
30ca5fb
updated ndf
veprbl Nov 4, 2026
1411cc0
Apply suggestion from @kkauder
kkauder Nov 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion edm4eic.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -542,7 +542,7 @@ datatypes:
Members:
- int32_t type // Type flag, to identify what type of vertex it is (e.g. primary, secondary, generated, etc.)
- float chi2 // Chi-squared of the vertex fit
- int ndf // NDF of the vertex fit
- float ndf // Ndf of the vertex fit, float allows for fractional numbers seen from AMVF - consistent with Acts EDM
- edm4hep::Vector4f position // position [mm] + time t0 [ns] of the vertex. Time is 4th component in vector
## this is named "covMatrix" in EDM4hep, renamed for consistency with the rest of edm4eic
- edm4eic::Cov4f positionError // Covariance matrix of the position+time. Time is 4th component, similarly to 4vector
Expand Down
Loading