Repository navigation
Make ndf into float in edm4eic::Vertex - #182
Merged
Merged
Conversation
wdconinc
previously approved these changes
Oct 19, 2026
wdconinc
left a comment
wdconinc
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Minimal and perfectly backwards compatible for reasonable ndf < 2^24 :-)
Member
Author
|
Alternatively we can switch to adopt |
Member
Author
|
... but then one needs to store this "ndf" into unnamed |
Member
Author
|
This was discussed Today in https://indico.bnl.gov/event/35288/, the consensus is that we are fine with aligning closer to Acts EDM. A comment by @kkauder (just addressed) was that we have to provide reasonable documentation for ndf that is float. |
kkauder
reviewed
Nov 4, 2026
kkauder
approved these changes
Nov 4, 2026
ruse-traveler
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: eic/EICrecon#3032
Upstream EDM
Acts::Vertexuses float for both chiSquared and numberDoF:https://github.com/acts-project/acts/blob/3bb5e23533409f98878c2d0510af313adcd52efa/Core/include/Acts/Vertexing/Vertex.hpp#L120
That is needed to support Annealing-type vertexing like AMVF:
https://github.com/acts-project/acts/blob/3bb5e23533409f98878c2d0510af313adcd52efa/Core/include/Acts/Vertexing/detail/KalmanVertexUpdaterImpl.hpp#L267
Alternatively we could add another field. This ndf is not Chi^2 distribution parameter. But then what would be the name is a question.
cc @osbornjd @wdconinc @Austinblabla @ShujieL