Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session-Id: 32c42430-6f51-4fb3-901e-04112f8b59fd
2 of 7 tasks
Contributor
Author
|
Failing CI run appears to be something that made its way onto main. I'm going to presume that is something the team is aware of and rebase onto a fix if it becomes available. |
pcapel
marked this pull request as ready for review
October 23, 2026 15:54
Contributor
|
🚀 Thank you for your contribution! 🚀 Decided to do it slightly differently, but based on your solution. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
listaggregate withuniq?and a sort on its own field fails when that field's column isvarchar:On this path (a3e39b1 keeps it for sorts on the aggregated field), the aggregated value is cast to the aggregate's type, but the
ORDER BYuses the bare column:On a
textcolumn the cast is a no-op, so the two expressions match and the existing tests pass. Onvarcharit's a real conversion, so they don't. This change orders by the samefieldexpression the aggregate uses, keeping each sort's direction:Sorts on other fields still take the
dedupe_sorted?path and aren't affected.The regression test is in ash-project/ash_postgres#906. It fails with 42P10 on
mainand passes with this change.Contributor checklist
Leave anything that you believe does not apply unchecked.
🤖 Generated with Claude Code