Repository navigation
test: cover uniq? list aggregates sorted by a varchar field - #906
Merged
zachdaniel merged 1 commit intoOct 24, 2026
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2 of 7 tasks
Contributor
Author
|
Comparing the CI failures here with existing failures, the only new one is the regression test as expected pending ash-project/ash_sql#277 merging and releasing. |
pcapel
marked this pull request as ready for review
October 23, 2026 15:59
Contributor
|
🚀 Thank you for your contribution! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test shows a bug in ash_sql. The fix is in ash-project/ash_sql#277
A
listaggregate withuniq?and a sort on its own field fails with 42P10 when the column isvarchar. The existinguniq_aggregate_sort_test.exstests usecomments.title, which istext, so they don't hit it. This adds alabelattribute toCommentwithmigration_types(label: {:varchar, 255}), auniq_comment_labelsaggregate onPost, and a test next to itstexttwin.The new test fails on ash_sql
mainand passes with the fix. The other five tests in the file pass either way.mix test.generate_migrationscreated the migration and snapshot fortest_repoonly. The PG18 run reported no changes, becauseuse_builtin_uuidv7_function?/0now defaults tofalseand both runs resolve totest_repo. That matches the other recent test migrations.Contributor checklist
Leave anything that you believe does not apply unchecked.
🤖 Generated with Claude Code