Skip to content

Fix puppeteer 25 esm #1870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
demiankatz merged 8 commits into from
Oct 20, 2026
Merged

Fix puppeteer 25 esm #1870

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
96b348b
Bump puppeteer from 23.6.0 to 25.12.0
dependabot[bot] Oct 5, 2026
99a54aa
Fix Puppeteer 25 ESM compatibility
LanieOkorodudu Oct 6, 2026
9bd3f15
Bump puppeteer from 23.6.0 to 25.13.0
dependabot[bot] Oct 12, 2026
2fda40e
Merge Dependabot Puppeteer 25.13.0 update
LanieOkorodudu Oct 12, 2026
b386f23
Bump puppeteer from 23.6.0 to 25.14.0
dependabot[bot] Oct 19, 2026
9316498
Merge upstream/dev and update AV and PDF tests for Puppeteer 25
LanieOkorodudu Oct 19, 2026
355205d
Merge Dependabot Puppeteer 25.14.0 update
LanieOkorodudu Oct 19, 2026
1c47c08
Merge upstream/dev and resolve package-lock.json conflict
LanieOkorodudu Oct 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion __tests__/av_tests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
const puppeteer = require("puppeteer");
let puppeteer;
const { BASE_URL } = require("../scripts/testBaseUrl");

// AV (audiovisual) manifest for AV-specific behaviour. A simple single-file
Expand Down Expand Up @@ -110,6 +110,7 @@ describe("Universal Viewer", () => {
let page;

beforeAll(async () => {
puppeteer = (await import("puppeteer")).default;
browser = await puppeteer.launch({
headless: true,
args: ["--no-sandbox", "--disable-setuid-sandbox"],
Expand Down
3 changes: 2 additions & 1 deletion __tests__/configuration_tests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
const puppeteer = require("puppeteer");
let puppeteer;
const { BASE_URL } = require("../scripts/testBaseUrl");

const FIRST_THUMB_SRC =
Expand All @@ -21,6 +21,7 @@ const applyCustomConfig = async (config) => {

describe("Configuration options", () => {
beforeAll(async () => {
puppeteer = (await import("puppeteer")).default;
browser = await puppeteer.launch();
page = await browser.newPage();
});
Expand Down
3 changes: 2 additions & 1 deletion __tests__/image_tests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
const puppeteer = require("puppeteer");
let puppeteer;
const { BASE_URL } = require("../scripts/testBaseUrl");

// Local paged book of static images, with ranges for the Index tab. Modelled
Expand Down Expand Up @@ -113,6 +113,7 @@ describe("Universal Viewer", () => {
};

beforeAll(async () => {
puppeteer = (await import("puppeteer")).default;
browser = await puppeteer.launch();
await openFreshViewer();
});
Expand Down
3 changes: 2 additions & 1 deletion __tests__/pdf_tests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
const puppeteer = require("puppeteer");
let puppeteer;
const { BASE_URL } = require("../scripts/testBaseUrl");

// Local multi-file PDF manifest (three single-page PDFs) for PDF-specific
Expand All @@ -15,6 +15,7 @@ describe("Universal Viewer", () => {
let page;

beforeAll(async () => {
puppeteer = (await import("puppeteer")).default;
browser = await puppeteer.launch({
headless: true,
args: ["--no-sandbox", "--disable-setuid-sandbox"],
Expand Down
Loading
Loading