Skip to content

Fix puppeteer 25 esm - #1870

Merged
demiankatz merged 8 commits into
UniversalViewer:devfrom
LanieOkorodudu:fix-puppeteer-25-esm
Oct 20, 2026
Merged

demiankatz merged 8 commits into
UniversalViewer:devfrom
LanieOkorodudu:fix-puppeteer-25-esm

Conversation

@LanieOkorodudu

@LanieOkorodudu LanieOkorodudu commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

Description of what you did:
This follows on from #1872
I've updated the tests to use dynamic import() so they work with Puppeteer 25. I also updated the Jest test command to run --experimental-vm-modules to support ESM. I tested the changes with Puppeteer 25.13.0 locally and the test and build are all passing.

dependabot Bot and others added 2 commits October 5, 2026 00:52
Bumps [puppeteer](https://github.com/puppeteer/puppeteer) from 23.6.0 to 25.12.0.
- [Release notes](https://github.com/puppeteer/puppeteer/releases)
- [Changelog](https://github.com/puppeteer/puppeteer/blob/main/CHANGELOG.md)
- [Commits](puppeteer/puppeteer@puppeteer-v23.6.0...puppeteer-v25.12.0)

---
updated-dependencies:
- dependency-name: puppeteer
  dependency-version: 25.12.0
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@vercel

vercel Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
universalviewer Ready Ready Preview Oct 20, 2026 2:53pm UTC

Request Review

@vercel

vercel Bot commented Oct 6, 2026

Copy link
Copy Markdown

@LanieOkorodudu is attempting to deploy a commit to the Universal Viewer Team on Vercel.

A member of the Team first needs to authorize it.

dependabot Bot and others added 2 commits October 12, 2026 02:31
Bumps [puppeteer](https://github.com/puppeteer/puppeteer) from 23.6.0 to 25.13.0.
- [Release notes](https://github.com/puppeteer/puppeteer/releases)
- [Changelog](https://github.com/puppeteer/puppeteer/blob/main/CHANGELOG.md)
- [Commits](puppeteer/puppeteer@puppeteer-v23.6.0...puppeteer-v25.13.0)

---
updated-dependencies:
- dependency-name: puppeteer
  dependency-version: 25.13.0
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

@demiankatz demiankatz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @LanieOkorodudu; I don't love being dependent on an experimental feature, but since this is only used for running tests, and if tests fail, we will immediately know about it, I suppose I can live with it if other approaches are unavailable or prohibitively complicated.

Since I just merged several new tests (in #1796), do you mind merging the dev branch into this PR so we can double-check that everything still passes? If so, I can approve and merge as long as nobody else objects in the meantime.

@demiankatz

Copy link
Copy Markdown
Contributor

@LanieOkorodudu, it might also be a good idea to merge in the latest jest release from #1872, since Dependabot has come up with a new version since we started this work.

@demiankatz

Copy link
Copy Markdown
Contributor

(Never mind, I see you're already ahead of me and have done that!) :-)

Bumps [puppeteer](https://github.com/puppeteer/puppeteer) from 23.6.0 to 25.14.0.
- [Release notes](https://github.com/puppeteer/puppeteer/releases)
- [Changelog](https://github.com/puppeteer/puppeteer/blob/main/CHANGELOG.md)
- [Commits](puppeteer/puppeteer@puppeteer-v23.6.0...puppeteer-v25.14.0)

---
updated-dependencies:
- dependency-name: puppeteer
  dependency-version: 25.14.0
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@LanieOkorodudu

Copy link
Copy Markdown
Contributor Author

Thanks, @LanieOkorodudu; I don't love being dependent on an experimental feature, but since this is only used for running tests, and if tests fail, we will immediately know about it, I suppose I can live with it if other approaches are unavailable or prohibitively complicated.

Since I just merged several new tests (in #1796), do you mind merging the dev branch into this PR so we can double-check that everything still passes? If so, I can approve and merge as long as nobody else objects in the meantime.

@demiankatz, Thanks for the feedback. Now dependabot just update it again 25.14.0. I will try my best to fix and finish it today.

@LanieOkorodudu

Copy link
Copy Markdown
Contributor Author

@demiankatz, I have updated the branch with the latest changes from upstream/dev and the Puppeteer 25.14.0 update from #1889 .
And yes I agree with your point that relying on a experimental Node.js feature is not ideal. I think it's reasonable approach for now. Otherwise, we could look at migrating our Jest setup from CommonJS to ESM as a separate piece of work.

@demiankatz

Copy link
Copy Markdown
Contributor

Thanks, @LanieOkorodudu, this looks reasonable to me. I think we have two options:

1.) I can approve and merge, and we can open an issue to track the need to migrate the Jest setup in future so we can eliminate the experimental feature.

2.) We can leave this open and put it in the appropriate section of the community board for discussion at the next Community Call in case others have concerns or are willing to help with the larger configuration improvement.

Please let me know if you have thoughts/preferences and I'll take the appropriate action!

@LanieOkorodudu

LanieOkorodudu commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor Author

Thanks, @LanieOkorodudu, this looks reasonable to me. I think we have two options:

1.) I can approve and merge, and we can open an issue to track the need to migrate the Jest setup in future so we can eliminate the experimental feature.

2.) We can leave this open and put it in the appropriate section of the community board for discussion at the next Community Call in case others have concerns or are willing to help with the larger configuration improvement.

Please let me know if you have thoughts/preferences and I'll take the appropriate action!

Thanks @demiankatz, We can merge this for now to address the #1889, and I will open an issue to track the need to migrate the Jest setup which I can start working on it from my side.

@demiankatz demiankatz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @LanieOkorodudu -- in that case, I'll approve and merge this to get things resolved.

@demiankatz demiankatz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, drat, the recent Dependabot PRs have introduced a conflict here in package-lock.json, and I don't currently have an environment set up where I can quickly fix it. Can you just delete package-lock.json, run npm i, and commit the result to get this back up to date? (I'll do it later if you don't have time either... but right now I need to get ready for the sprint!)

@LanieOkorodudu

Copy link
Copy Markdown
Contributor Author

Oh, drat, the recent Dependabot PRs have introduced a conflict here in package-lock.json, and I don't currently have an environment set up where I can quickly fix it. Can you just delete package-lock.json, run npm i, and commit the result to get this back up to date? (I'll do it later if you don't have time either... but right now I need to get ready for the sprint!)

Thanks @demiankatz, All done now.

@demiankatz demiankatz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again, @LanieOkorodudu!

@demiankatz
demiankatz merged commit f5b856b into UniversalViewer:dev Oct 20, 2026
4 of 5 checks passed

This branch was successfully deployed

1 active deployment
Preview – universalviewer — 1c47c084 Deployed Oct 20, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants