Repository navigation
Fix puppeteer 25 esm - #1870
Fix puppeteer 25 esm#1870
Conversation
Bumps [puppeteer](https://github.com/puppeteer/puppeteer) from 23.6.0 to 25.12.0. - [Release notes](https://github.com/puppeteer/puppeteer/releases) - [Changelog](https://github.com/puppeteer/puppeteer/blob/main/CHANGELOG.md) - [Commits](puppeteer/puppeteer@puppeteer-v23.6.0...puppeteer-v25.12.0) --- updated-dependencies: - dependency-name: puppeteer dependency-version: 25.12.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@LanieOkorodudu is attempting to deploy a commit to the Universal Viewer Team on Vercel. A member of the Team first needs to authorize it. |
Bumps [puppeteer](https://github.com/puppeteer/puppeteer) from 23.6.0 to 25.13.0. - [Release notes](https://github.com/puppeteer/puppeteer/releases) - [Changelog](https://github.com/puppeteer/puppeteer/blob/main/CHANGELOG.md) - [Commits](puppeteer/puppeteer@puppeteer-v23.6.0...puppeteer-v25.13.0) --- updated-dependencies: - dependency-name: puppeteer dependency-version: 25.13.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
demiankatz
left a comment
There was a problem hiding this comment.
Thanks, @LanieOkorodudu; I don't love being dependent on an experimental feature, but since this is only used for running tests, and if tests fail, we will immediately know about it, I suppose I can live with it if other approaches are unavailable or prohibitively complicated.
Since I just merged several new tests (in #1796), do you mind merging the dev branch into this PR so we can double-check that everything still passes? If so, I can approve and merge as long as nobody else objects in the meantime.
|
@LanieOkorodudu, it might also be a good idea to merge in the latest jest release from #1872, since Dependabot has come up with a new version since we started this work. |
|
(Never mind, I see you're already ahead of me and have done that!) :-) |
Bumps [puppeteer](https://github.com/puppeteer/puppeteer) from 23.6.0 to 25.14.0. - [Release notes](https://github.com/puppeteer/puppeteer/releases) - [Changelog](https://github.com/puppeteer/puppeteer/blob/main/CHANGELOG.md) - [Commits](puppeteer/puppeteer@puppeteer-v23.6.0...puppeteer-v25.14.0) --- updated-dependencies: - dependency-name: puppeteer dependency-version: 25.14.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
@demiankatz, Thanks for the feedback. Now dependabot just update it again 25.14.0. I will try my best to fix and finish it today. |
|
@demiankatz, I have updated the branch with the latest changes from |
|
Thanks, @LanieOkorodudu, this looks reasonable to me. I think we have two options: 1.) I can approve and merge, and we can open an issue to track the need to migrate the Jest setup in future so we can eliminate the experimental feature. 2.) We can leave this open and put it in the appropriate section of the community board for discussion at the next Community Call in case others have concerns or are willing to help with the larger configuration improvement. Please let me know if you have thoughts/preferences and I'll take the appropriate action! |
Thanks @demiankatz, We can merge this for now to address the #1889, and I will open an issue to track the need to migrate the Jest setup which I can start working on it from my side. |
demiankatz
left a comment
There was a problem hiding this comment.
Thanks, @LanieOkorodudu -- in that case, I'll approve and merge this to get things resolved.
demiankatz
left a comment
There was a problem hiding this comment.
Oh, drat, the recent Dependabot PRs have introduced a conflict here in package-lock.json, and I don't currently have an environment set up where I can quickly fix it. Can you just delete package-lock.json, run npm i, and commit the result to get this back up to date? (I'll do it later if you don't have time either... but right now I need to get ready for the sprint!)
Thanks @demiankatz, All done now. |
demiankatz
left a comment
There was a problem hiding this comment.
Thanks again, @LanieOkorodudu!
Description of what you did:
This follows on from #1872
I've updated the tests to use dynamic
import()so they work with Puppeteer 25. I also updated the Jest test command to run--experimental-vm-modulesto support ESM. I tested the changes with Puppeteer25.13.0locally and the test and build are all passing.