Repository navigation
Core - Fix node script and pin bugs found by the tests - #911
Merged
Merged
Conversation
…s from in node scripts - Saving a script keeps nodes whose plugin is missing, and their connections, so they come back once the plugin is available again - Loading keeps the first connection of an input, the one it reads from - Disabling a node provider only removes the nodes it created, not those of another provider registering the same type - RemoveNode only raises NodeRemoved for nodes that were in the script
- Connecting pins that are already connected no longer adds a second connection - Untyped pins turn null into the default value for value types, as intended - A new InputPin<T> reads its connection right away instead of after its first reset - Matching a specific enum to a pin of any enum now depends on forgivingEnumMatching - A node that fails to evaluate sets its outputs to their default values, so it is evaluated once per run and old values don't flow on
RobertBeekman
marked this pull request as ready for review
October 24, 2026 14:19
RobertBeekman
added a commit
that referenced
this pull request
Oct 27, 2026
) A node that failed to evaluate reset its outputs to their default values, so a node breaking for a few frames made everything after it jump to defaults. It now keeps the outputs of its last successful run, like before #911, and still marks them as evaluated so it isn't evaluated again for every pin reading from it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the node script and pin bugs found by the test suite (#907). Each fix flips the test that pinned the old behaviour.
Fixed
Numericconversions are consistent. Converting tolongrounds like converting tointdoes, andToSByteclamps to -128..127 instead of 0..255.RemoveNodeonly raisesNodeRemovedfor nodes that were in the script.forgivingEnumMatchingoption ofIsTypeCompatiblenow decides whether a specific enum matches a pin of any enum.nullinto the default value for value types, like their code comment says.InputPin<T>reads its connection right away instead of after its first reset.Known limitation, left as is
Convert.ToInt32(numeric)and similar calls pick thebyteoverload, becauseNumericconverts implicitly tobyte. Fixing that means removing implicit conversions, which would break plugins. The test stays and is marked as a known limitation.Testing
Artemis.Core.Tests: 1385 passedArtemis.UI.Shared.Tests: 176 passed