Repository navigation
Core - Keep the last good outputs of a node that fails to evaluate - #917
Merged
Merged
Conversation
A node that failed to evaluate reset its outputs to their default values, so a node breaking for a few frames made everything after it jump to defaults. It now keeps the outputs of its last successful run, like before #911, and still marks them as evaluated so it isn't evaluated again for every pin reading from it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partly reverts a change from #911. A node that failed to evaluate reset its outputs to their default values, so a node breaking for a few frames made everything after it jump to defaults. That's more noticeable than carrying on with the last good values for a moment.
Changed
Pin.SetDefaultValue, nothing else used it.Difference with before #911
Before #911 a failing node was tried again for every input reading from it. A node that only fails sometimes could succeed on a later read in the same frame, now that waits until the next frame.