Repository navigation
fix(action-sheet): forward open-type callbacks - #6093
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The callback forwarding and button-ID support are consistent across all templates with no unresolved issues.
0 open findings
What changed in this PR
Forwards ActionSheet native button callbacks and supports per-action button IDs.
Changes:
- Binds real-time phone and privacy authorization callbacks.
- Adds and documents
actions[].buttonId. - Synchronizes source,
lib, anddisttemplates.
| File | Description |
|---|---|
packages/action-sheet/README.md |
Documents buttonId. |
packages/action-sheet/index.wxml |
Adds IDs and callback bindings. |
lib/action-sheet/index.wxml |
Synchronizes library template. |
dist/action-sheet/index.wxml |
Synchronizes distribution template. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ActionSheet actions using
agreePrivacyAuthorizationorgetRealtimePhoneNumberdid not forward native button results to their documented component events. Bind the existing handlers and supportactions[].buttonIdas the native button ID, allowing custom privacy authorization flows to resolve the correct button.Document the new action option and synchronize the affected
distandlibtemplates.Validation:
miniprogram-simulateverification passed for per-action button IDs, both callbacks and the combinedgetRealtimePhoneNumber|agreePrivacyAuthorizationopen type.git diff --checkpassed.