Repository navigation
build: require osam 0.11.8 - #3106
Merged
Merged
Conversation
osam 0.11.8 stops the AI server as soon as labelme quits, instead of up to 5 seconds later, and cleans up a model download it interrupts.
Owner
Author
recommend-merge No verified defects found.
The full suite was not rerun locally. All completed CI checks passed; three macOS test jobs remain in progress. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
osam 0.11.8 (wkentaro/osam#298) makes labelme's AI server exit as soon as labelme quits, instead of up to 5 s later, and cleans up a model download it interrupts. labelme's code is unchanged.
Evidence
ResourceWarning: unclosed file.After: With osam 0.11.8 on macOS, the server exits 0.07 s after its parent, versus 5.08 s on 0.11.7. The measurements are in osam Guideline for adding new label shapes and enabling rotation? #298.
uv.lockresolves osam 0.11.8. The full suite passes (2573 passed, 11 skipped), and lint is clean.Merge Danger
Door: two-way
Blast Radius: small
Installs need osam 0.11.8, which is already on PyPI. Codex review found nothing.