Skip to content

build: require osam 0.11.8 - #3106

Merged
wkentaro merged 2 commits into
mainfrom
build/osam-0.11.8
Nov 14, 2026
Merged

wkentaro merged 2 commits into
mainfrom
build/osam-0.11.8

Conversation

@wkentaro

@wkentaro wkentaro commented Nov 14, 2026 •

Copy link
Copy Markdown
Owner

Summary

 dependencies = [
-  "osam>=0.11.6,<0.12",
+  "osam>=0.11.8,<0.12",

osam 0.11.8 (wkentaro/osam#298) makes labelme's AI server exit as soon as labelme quits, instead of up to 5 s later, and cleans up a model download it interrupts. labelme's code is unchanged.

Evidence

  • Before: A labelme test on Windows found that after quitting during a SAM 3 request, the osam server kept running for 5 to 6 s, and shutdown printed ResourceWarning: unclosed file.
    After: With osam 0.11.8 on macOS, the server exits 0.07 s after its parent, versus 5.08 s on 0.11.7. The measurements are in osam Guideline for adding new label shapes and enabling rotation? #298.
  • uv.lock resolves osam 0.11.8. The full suite passes (2573 passed, 11 skipped), and lint is clean.

Merge Danger

Door: two-way

Blast Radius: small

Installs need osam 0.11.8, which is already on PyPI. Codex review found nothing.

osam 0.11.8 stops the AI server as soon as labelme quits, instead of
up to 5 seconds later, and cleans up a model download it interrupts.
@wkentaro

Copy link
Copy Markdown
Owner Author

This was generated by AI (gpt-6.1-sol) during PR review.

recommend-merge

No verified defects found.

  • Meaningful: osam 0.11.6 on main waits five seconds before forcing its private server to exit.
  • Worth adding: the patch update improves shutdown and download cleanup without adding application code.
  • Right approach: osam owns the server lifecycle, so requiring its upstream fix addresses the cause.
  • Correct: the manifest and lockfile agree on 0.11.8. All 30 targeted dependency, download, and AI worker tests passed.
  • Minimal: only the dependency floor, locked package, and required changelog fragment changed.

The full suite was not rerun locally. All completed CI checks passed; three macOS test jobs remain in progress.

@wkentaro wkentaro added the recommend-merge pr: Agent finalized and endorses it: review and merge label Nov 14, 2026
@wkentaro
wkentaro merged commit 094c3fa into main Nov 14, 2026
22 checks passed
@wkentaro
wkentaro deleted the build/osam-0.11.8 branch November 14, 2026 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

recommend-merge pr: Agent finalized and endorses it: review and merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant