Repository navigation
ci(github): use a closing keyword in the pull request template - #826
Merged
Merged
Conversation
"Resolves issue #823" does not link a pull request to the issue: GitHub expects the keyword directly before the reference, and the word "issue" in between breaks it. #824 targeted the default branch with that line and was never linked to #823. The template now reads "Resolves #", and its comment says to repeat the keyword for each issue, since one keyword links only the reference that follows it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The template's
Resolves issue #line never links a pull request to its issue: GitHub expects the closing keyword directly before the reference, and the word "issue" in between breaks it. #824 targeted the default branch withResolves issue #823and was never linked to #823.The line now reads
Resolves #. Its comment says to repeat the keyword for each issue (Resolves #1, resolves #2), since one keyword links only the reference that follows it.GitHub reads pull request templates from the default branch only, so the change is made on
4.3.x.