Repository navigation
fix: make test_statistics_extra_prediction_paths pass on totalseg_v3 - #646
Open
harshpatel wants to merge 1 commit into
Open
harshpatel wants to merge 1 commit into
harshpatel wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"Run detailed tests" has failed on every push to
totalseg_v3since Oct 6 (last passed on Oct 2). The cause is one test, not the package code.The cause
test_statistics_extra_prediction_pathscame from master in #621. It mocksnnUNetv2_predict. Ontotalseg_v3, normal inference runs in memory and no longer calls that function, so nnU-Net tries to build the real predictor and stops with "Could not find a dataset with the ID 831". The test has 12 parametrized cases and all 12 fail. The other 2 tests intests/test_research_utils.pypass.The change
tests/test_research_utils.pyonly. The mock now replaces the in-memory steps (_build_nnunetv2_predictor,_initialize_nnunetv2_predictor,_create_nnunetv2_predictor,_preprocessing_signature,_preprocess_nnunet_array, and_predict_preprocessed_nnunet_array) and returns the same synthetic spleen mask as before. The assertions are unchanged.Testing
extra_metrics=Falsein the low-resolution path), the same four cases fail as in fix: include extra statistics in low-resolution runs #621, so the test still catches that bug.ruffpasses.tests/tests.shstops at the first failure, so the steps after this test have not run on this branch since Oct 2. I did not run them because they need the weights and a license. Something further down may still fail.If you would rather remove this test on
totalseg_v3, feel free to close this PR.