Skip to content

fix: pass format args directly - #861

Merged
tenthirtyam merged 1 commit into
mainfrom
fix/pass-format-args-directly
Nov 2, 2026
Merged

tenthirtyam merged 1 commit into
mainfrom
fix/pass-format-args-directly

Conversation

@tenthirtyam

Copy link
Copy Markdown
Collaborator

Summary

The bump to hashicorp/packer-plugin-sdk v0.6.13 moved that module to Go 1.26, so vet now treats Ui.Errorf as a printf wrapper. PackerLogger.Error forwards to it, and the content-library lookup was passing a fmt.Sprintf result as the format string, which failed.

Type

  • fix: Bug Fix
  • feat: Feature or Enhancement
  • docs: Documentation
  • refactor: Refactoring
  • chore: Build, Dependencies, Workflows, etc.
  • other: Other (Please describe.)

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

Tests

  • Tests have been added or updated.
  • Tests have been completed.

Output:

Documentation

  • Documentation has been added or updated.

Issue References

Release Note

Additional Information

The bump to `hashicorp/packer-plugin-sdk` v0.6.13 moved that module to Go 1.26, so `vet` now treats `Ui.Errorf` as a `printf` wrapper. `PackerLogger.Error` forwards to it, and the content-library lookup was passing a `fmt.Sprintf` result as the format string, which failed.

Signed-off-by: Ryan Johnson <ryan@tenthirtyam.org>
@tenthirtyam
tenthirtyam requested a review from a team as a code owner November 2, 2026 19:41
@tenthirtyam tenthirtyam added this to the v2.5.1 milestone Nov 2, 2026
@github-actions github-actions Bot added the needs-review Needs Review label Nov 2, 2026
@tenthirtyam tenthirtyam added technical-debt Technical Debt and removed needs-review Needs Review labels Nov 2, 2026
@tenthirtyam tenthirtyam self-assigned this Nov 2, 2026
@github-actions github-actions Bot added the size/xs Relative Sizing: Extra-Small label Nov 2, 2026
@tenthirtyam
tenthirtyam merged commit b7fae92 into main Nov 2, 2026
12 checks passed
@tenthirtyam
tenthirtyam deleted the fix/pass-format-args-directly branch November 2, 2026 19:47
@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown

This functionality has been released in v2.5.1 of the plugin.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/xs Relative Sizing: Extra-Small technical-debt Technical Debt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant