Repository navigation
fix(sinks): report cancelled in-flight requests as errored - #26836
Draft
thomasqueirozb wants to merge 1 commit into
Draft
thomasqueirozb wants to merge 1 commit into
thomasqueirozb wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a
Driver-based sink is cancelled, for example when--reload-sink-drain-limit-secsexpires, its in-flight requests are dropped. Their finalizers reported the events asDelivered, so sources with end-to-end acknowledgements acknowledged data that was not sent. These events are now reported asErrored. Requests that complete keep the status from their response.Delivered. The source acknowledges them and they are lostErrored. The source can retry themDriver, and sinks whose requests complete before the remote confirms them (for examplemqtt)DeliveredDeliveredWhat a retry means depends on the source. Keeping cancelled records in disk buffers needs a separate status and a reader rewind on buffer reuse, which is out of scope here.
References
Depends on: #26834
Related: #26793
Vector configuration
NA
How did you test this PR?
Unit tests in
vector-streamdriver::tests: a cancelled request reportsErrored, and a completed request keeps the status from its response.Does this PR include user facing changes?
no-changeloglabel to this PR.