Skip to content

fix(pms): accept property-created manual bookings [VAY-1260] - #1023

Merged
FlamurMaliqi merged 1 commit into
mainfrom
flamurmaliqi2811/vay-1260-manual-contact-acceptance
Aug 15, 2026
Merged

FlamurMaliqi merged 1 commit into
mainfrom
flamurmaliqi2811/vay-1260-manual-contact-acceptance

Conversation

@FlamurMaliqi

@FlamurMaliqi FlamurMaliqi commented Aug 15, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • record one private property-acceptance status event when a property user creates an already-confirmed manual booking
  • let the existing commission-plan contact policy recognize that property-owned acceptance without weakening marketplace booking privacy
  • prove exact event fields, atomic replay behavior, and canonical guest contact visibility in PostgreSQL

Verification

  • adversarial review: CLEAN
  • PostgreSQL 17 manual-booking integration: 30/30
  • focused command tests: 3/3
  • full monorepo typecheck
  • architecture boundaries
  • API TypeScript
  • git diff --check

Scope

  • 44 changed non-generated lines
  • follow-up from deployed VAY-1260 smoke run 31888625690

Summary by CodeRabbit

  • New Features

    • Booking acceptance now records a visible status event with the acting property user and requested timestamp.
    • Guest booking projections now include the guest’s email address and phone number.
  • Tests

    • Added coverage validating the acceptance event’s status, actor, visibility, payload, timestamp, and related booking details.

@coderabbitai

coderabbitai Bot commented Aug 15, 2026 •

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 8e98202e-458d-41a1-996c-d6b1bc3fa728

📥 Commits

Reviewing files that changed from the base of the PR and between 00d5d29 and 8f0c611.

📒 Files selected for processing (2)
  • apps/api/src/domains/pmsManualBookingCommandRepository.integration.test.ts
  • apps/api/src/domains/pmsManualBookingPersistence.ts

📝 Walkthrough

Walkthrough

The manual booking persistence flow now records a non-public guest_booking.accepted event with confirmation metadata. Integration coverage verifies the event and checks projected guest contact fields.

Changes

Manual booking acceptance

Layer / File(s) Summary
Persist acceptance event
apps/api/src/domains/pmsManualBookingPersistence.ts
persistBookingFacts inserts a non-public guest_booking.accepted event with a confirmed status, property-user actor, contract version, and requested timestamp.
Verify event and guest projection
apps/api/src/domains/pmsManualBookingCommandRepository.integration.test.ts
The integration test verifies the stored event fields and requires the projected primary guest to include email, phone, and special requests.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 8f0c6

The change is localized to manual-booking persistence and its integration coverage, with no actionable merge-blocking risk remaining after normal checks and review.

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: accepting property-created manual bookings in PMS handling.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Comment @coderabbitai help to get the list of available commands.

@FlamurMaliqi
FlamurMaliqi merged commit 36aab20 into main Aug 15, 2026
11 checks passed
@FlamurMaliqi
FlamurMaliqi deleted the flamurmaliqi2811/vay-1260-manual-contact-acceptance branch August 15, 2026 14:16
@FlamurMaliqi
FlamurMaliqi restored the flamurmaliqi2811/vay-1260-manual-contact-acceptance branch August 15, 2026 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant