Repository navigation
🐛 fix(xpath): walk and/or chains without recursion - #1631
Merged
Merged
Conversation
gaborbernat
enabled auto-merge (squash)
November 5, 2026 14:38
Merging this PR will not alter performance
Comparing Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node.xpathfailed withValueError: xpath: an expression nested too deeplyon anyandororchain of more than 1,024 operands (#1629).css_to_xpathjoins the parts of a compound selector withand, so a compound selector of 511 or more classes failed throughxpath()whileselect()matched it. Such chains now evaluate. This finishes what #1608 did for selector lists and unions. 🔍The evaluator now treats a run of the same boolean operator the way it treats a union: it walks the chain once and evaluates the operands in a loop, left to right, stopping at the first operand that decides the result, as before. Each operand still counts its own nesting against the depth cap, so a deeply nested group inside a chain raises as it did, and comparison or arithmetic chains (
1 = 1 = 1,1 + 1 + 1) keep the cap (#421).Evaluating an
andororchain now allocates one small array of operand indices per evaluation.Closes #1629