Repository navigation
🐛 fix(css): keep stray text out of joined media - #1626
Merged
Merged
Conversation
A same-query @media block following one that ends in stray text was joined onto it, so the text became the first joined rule's selector and a second pass changed the output. Keep such blocks apart.
gaborbernat
enabled auto-merge (squash)
November 5, 2026 00:29
Merging this PR will not alter performance
Comparing 
Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
minify_csswas not a fixpoint on{}@media screen{, )}@media screen{b{h:-}}: the first pass gave@media screen{, )b{h:-}}and the second gave@media screen{,)b{h:-}}. #1615 did not cover it.An
@mediablock that ends in stray text (, ), kept verbatim as error recovery) was joined with the next same-query block, so the text became the selector of the first joined rule. Such a block now stays separate; blocks ending in a;-terminated statement still join.