Skip to content

adding scprint-2 - #90

Merged
szalata merged 7 commits into
theislab:mainfrom
jkobject:main
Aug 16, 2026
Merged

szalata merged 7 commits into
theislab:mainfrom
jkobject:main

Conversation

@jkobject

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings December 28, 2025 16:02

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds the scPRINT-2 model to the repository's curated list of single-cell transformers and updates the original scPRINT entry with its new peer-reviewed publication status. The PR also adds corresponding evaluation benchmark entries for both models.

Key changes:

  • New scPRINT-2 model entry with 350M training dataset and expanded capabilities
  • Updated scPRINT entry showing transition from preprint to Nature Communications publication
  • New evaluation benchmark entries comparing scPRINT-2 against 42+ foundation models

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread README.md Resolved
Comment thread README.md Resolved
Comment thread README.md Resolved
Comment thread README.md Resolved
@szalata

szalata commented Dec 30, 2025

Copy link
Copy Markdown
Collaborator

Thank you for the PR and congratulations on the paper! Note that updates via README are outdated now and you can add the model information to the yaml. This fixes the messy changelogs. https://github.com/theislab/single-cell-transformer-papers/blob/main/_data/single-cell-transformers.yml
I see you included evaluation entries too for the papers. Note that we intended to leave the evaluation to evaluation-focused papers, i.e. benchmarks only. This is to narrow down to comparisons that are less likely to be biased toward any particular model.

@jkobject

Copy link
Copy Markdown
Contributor Author

Addressed the requested source-of-truth/policy changes in b12c747:

  • moved the scPRINT-2 addition and scPRINT publication update into _data/single-cell-transformers.yml
  • restored README to the current base (no obsolete generated table edits)
  • omitted both method-paper evaluation entries, per the benchmark-only evaluation policy
  • retained model facts and corrected links in the YAML records

Validation: Ruby/Psych parsed the YAML and asserted exactly one scPRINT and scPRINT-2 record plus scPRINT peer-reviewed status; npm run build passed; bundle exec jekyll build passed (with the repository’s existing duplicate-destination warnings); git diff --check upstream/main...HEAD passed. The final PR diff is one source file: 22 insertions, 5 deletions.

@jkobject

Copy link
Copy Markdown
Contributor Author

Independent review of immutable revision b12c7472d43f09a0c30d6b09b72f2bb2c4688f7d: APPROVED / PASS.

Verified against base 7ab9c7d8e086a5b58f41eaf0fb411f157bb6d44c:

  • GitHub compare reports ahead 6 / behind 0.
  • The complete PR diff is exactly one file, _data/single-cell-transformers.yml (22 additions, 5 deletions); README and evaluation entries are absent.
  • YAML parses and contains exactly one schema-consistent record each for scPRINT and scPRINT-2.
  • scPRINT is marked peer reviewed and links to the verified Nature Communications article/DOI; scPRINT-2 links to its verified preprint DOI and live cantinilab/scPRINT-2 repository.
  • git diff --check and npm run build pass locally.
  • GitHub convert check is completed successfully for this exact SHA.
  • PR remains open/unmerged; the only reported merge block is the required repository review.

No blocking findings. I did not merge or close the PR.

The scPRINT/scPRINT-2 zero_shot_tasks data added to
single-cell-transformers.yml was never rendered because
single-cell-transformers.jsx omitted it from processedData and the
FilterableTable columns list, unlike the sibling transformer-llms.jsx
page which already maps this field.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@szalata
szalata merged commit f13e210 into theislab:main Aug 16, 2026
1 check passed
@szalata

szalata commented Aug 16, 2026

Copy link
Copy Markdown
Collaborator

Thank you for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants