Repository navigation
chore(docs): upgrade Blume to 2.2.3 - #789
Merged
Merged
Conversation
Blume 2 replaces the keyed config blocks with adapters imported from
`blume/*` subpaths, so `blume.config.ts` moves to `vercel()` from
`blume/analytics` and `filesystem()`/`custom()` from `blume/sources`.
`ai.llmsTxt` becomes `agents.llmsTxt`, and the `deployment` block goes
away entirely since it only pinned `output: "static"`, now the default
when no host adapter is named.
Two breakages the upgrade check could not see:
`theme.css` hid `[data-blume-header] > .flex.items-center.gap-2` below
30rem to make room for the logo lockup, which in Blume 1 matched the
header's right-hand action group. Blume 2 re-laid out the header and the
selector started matching the left branding group instead, so the logo
and the nav drawer toggle vanished on phones. Blume 2's header fits the
lockup down to 320px, so the rule is simply dropped.
`sources/github-releases.ts` wraps the release source only to stamp
`search: { exclude: true }` on each entry, keeping 100+ changelog pages
out of the search index. Blume 2 rebuilds a `custom()` source on the
scan's own context via `withContext`, which the wrapper inherited from
the source it spread, handing Blume back an unwrapped source and
silently dropping the exclusion. It now re-wraps on rebuild. The raw
source also moved to `blume/core/sources/github-releases.ts`, since
`blume/sources/github-releases.ts` is the new adapter factory.
Verified: build, doctor, check, validate and lint pass, and the built
search index holds no `/changelog/` routes, matching Blume 1.
|
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
commit: |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades the docs site from Blume 1.2.1 to 2.2.3, following the Blume 2 upgrade guide.
Config migration
Blume 2 replaces the keyed config blocks with adapters imported from
blume/*subpaths:analytics: { vercel: true }becomesanalytics: [vercel()]fromblume/analyticscontent.sourcesentries becomefilesystem({ root: "docs" })andcustom(...)fromblume/sourcesai.llmsTxtmoves toagents.llmsTxtdeploymentblock is removed: it only pinnedoutput: "static", which is the default when no host adapter is namedcomponents.tsalready used the accepted Blume 2 form and needed no change.npx blume upgradereports nothing left to change.Two breakages the upgrade check could not see
Both were found by verifying the built site rather than by any command exiting zero, so they are the parts worth reviewing.
Mobile header collapsed.
theme.csshid[data-blume-header] > .flex.items-center.gap-2below 30rem to make room for the logo lockup. In Blume 1 that selector matched the header's right-hand action group. Blume 2 re-laid out the header, so it started matching the left branding group instead, and the logo plus the nav drawer toggle disappeared on phones. Blume 2's header fits the lockup down to 320px, so the rule is dropped rather than retargeted. Checked at 320, 375, 560 and 768px on both the landing page and the docs pages.Changelog pages leaked into search.
sources/github-releases.tswraps the release source only to stampsearch: { exclude: true }on each entry, keeping 100+ release pages out of the search index. Blume 2 rebuilds acustom()source on the scan's own context by callingwithContext, which the wrapper inherited from the source it spread, so Blume got an unwrapped source back and the exclusion was silently discarded. The wrapper now re-wraps on rebuild. The raw source factory also moved toblume/core/sources/github-releases.ts, sinceblume/sources/github-releases.tsis now the adapter factory.To confirm this was a regression rather than something pre-existing, the docs were built at the pre-upgrade commit: Blume 1 indexed 9 routes with 0 changelog entries, Blume 2 indexed 109 with all 100 changelog pages. After the fix it is back to 9 and 0.
Verification
blume build,blume doctor,blume check,blume validateandbiome checkall pass, as do the library and docsturbolint/typecheck/test tasks. The built site keeps its 301 changelog files,llms.txt, and static output.Notes for the reviewer
storybook#typecheckfails ontsconfig.jsonoptiondownlevelIterationbeing removed in TypeScript 7. This is pre-existing on this branch and unrelated: the committed lockfile already resolved typescript 7.0.2 for that workspace and its tsconfig is untouched here. Left for a separate change.pnpm installre-resolved some shared transitive versions (vite, yaml, postcss), which is why the lockfile diff is large.oxc-transform-reactpeer warning appears under@astrojs/react. It does not affect the build.