Repository navigation
Require contiguous history for backfillHistory - #12741
Open
stuart-wells wants to merge 1 commit into
Open
stuart-wells wants to merge 1 commit into
stuart-wells wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
backfillHistorynow checks the history it receives from the source cluster. Event IDs must run on from the start with no gaps, each event's version must match the snapshot's version history, and the stream must reach the snapshot's last event. If any check fails, it returns a retryableInternalerror instead of persisting mutable state.Why?
GetWorkflowExecutionRawHistoryV2can end early without an error. For example, its continuation token pins the branch token from page 1, so if the source moves the run to another storage tier between pages, the last range reads as empty with no next token.The pagination issue will be fixed in another PR, but this is being kept for hardening.
How did you test it?
Potential risks
Related to #12742