Repository navigation
Add test for newline before WithClause - #5147
tuankiet65 wants to merge 1 commit into
Conversation
This commit adds test for newline before WithClause in ImportDeclaration and ExportDeclaration. This was allowed since [1]. [1]: tc39/proposal-import-attributes#136
hexbinoct
left a comment
hexbinoct
left a comment
There was a problem hiding this comment.
I ran this locally. On node 24.14.0 (V8) the test passes, and engine262 parses it as a module. To check the newline is what the test depends on, I put a ; after each module specifier. Both engines then reject the file, because the next line becomes a with statement, which is not allowed in module code. Changing the expected 262.1 makes the assertion fail on V8.
The spec matches: ImportDeclaration and ExportDeclaration have WithClause? right after the specifier, with no [no LineTerminator here].
allow-nlt-before-with.js in the same directory already covers a newline before with, but only for import * as x from and only as a parse check. This one adds the bare import, a default import that is actually evaluated, and both export ... from forms, so I think they complement each other.
Two small things:
globalThisinfeaturesisn't used by this test.- The
infoblock could showWithClause?, as the spec does. On that note,import-attribute-newlines.jsstill saysimport ModuleSpecifier[no LineTerminator here] WithClause;in itsinfo, which is the old restriction this test shows is gone. That could be fixed here too if you like.
Looks good to me otherwise.
This commit adds test for newline before WithClause in ImportDeclaration and ExportDeclaration. This was allowed in tc39/proposal-import-attributes#136.