Repository navigation
fix(prover): accept Glamsterdam L1 block access list hashes - #61
Merged
Merged
Conversation
Glamsterdam L1 headers carry the EIP-7928 block access list hash, and the L1 block hash commits to it. gaiko2 rejected that field in every header, so any proposal whose origin block comes after the fork could not be proven. The pinned taiko-geth header also had no such field, so the recomputed L1 hash would not have matched either. - Bump taiko-geth to taikoxyz/taiko-geth#611 (f2fe2fd49), whose header keeps the block access list hash. - Decode taiko.l1_header and taiko.l1_ancestor_headers with the field. L2 headers still reject it. - Pin a real Sepolia header hash and cover anchor linkage with Glamsterdam L1 headers. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Pin the taiko branch squash commit of taikoxyz/taiko-geth#611 (8a71a2ecb). Its tree is identical to the reviewed PR head f2fe2fd49. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
smtmfft
approved these changes
Oct 9, 2026
smtmfft
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed at ee13f4f. The L1-only decoder preserves the Glamsterdam block access list hash for canonical header hashing while L2 replay continues to reject the field. The pinned taiko-geth squash commit matches the reviewed #611 tree, real-header and manifest-binding regressions cover the affected paths, and CI is green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Glamsterdam L1 headers carry the EIP-7928 block access list hash, and the L1 block hash commits to it.
field block_access_list_hash is not supported by taiko-geth replay). Once L1 forks, every proposal whose origin block is post-fork fails to prove (fail-closed).types.Headerhas no such field, so the recomputedtaiko.l1_headerhash would not matchproposal.originBlockHash, and the anchor checkpoint hashes would not match either.Changes:
taiko,8a71a2ecb3b7(v1.18.1-0.20261009020728-8a71a2ecb3b7). Itstypes.HeaderkeepsBlockAccessListHashin the canonical position, beforeSlotNumber. Its tree is identical to the reviewed PR headf2fe2fd498d2.decodeL1Headerkeeps the field fortaiko.l1_headerandtaiko.l1_ancestor_headers.decodeHeader, which decodes L2 headers, still rejects it with the same error.Rollout
taikosquash commit, so it is ready to merge.8e98046bfd6a: five CI-only commits (#602, #603, #606, #607, #609), plus #611.Verification
TestDecodeGuestInputL1HeadersKeepsGlamsterdamHeaderHash: real Sepolia block 11873940 (testdata/l1_header_sepolia_11873940_glamsterdam.json). The decoded origin and ancestor hash0xfd4eb21751cb7c7d94d75f61c9f6364558923a2db73599f9ed917ee65d8c5680matcheseth_getBlockByNumber.TestValidateManifestBindingAcceptsGlamsterdamL1Headers: full manifest binding with L1 headers that carry a block access list hash and slot number.TestDecodeHeaderRejectsNonNullBlockAccessListHashstill passes.go mod verifygo mod tidy -diffgo vet ./...go build ./...go test -count=1 ./...go test -race -count=1 ./cmd/gaiko2 ./internal/api ./internal/teegit diff --check origin/maininternal/provertests also pass withGOTOOLCHAIN=go1.24.0, the CI toolchain.🤖 Generated with Claude Code