Repository navigation
fix: memory leak on logout and account switch - #1808
Draft
Arsabutispik wants to merge 1 commit into
Draft
Arsabutispik wants to merge 1 commit into
Arsabutispik wants to merge 1 commit into
Conversation
Signed-off-by: İspik <ispik@ispik.dev>
Arsabutispik
force-pushed
the
fix/memory-leak
branch
from
November 20, 2026 14:13
c764892 to
e2afef7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix memory leak on logout/account switch
Fixes #1083
Waiting on stoatchat/javascript-client-sdk#206
Logging out and back in (or switching accounts) kept the previous
Clientalive, so RAM grew with every cycle.Causes found (via Chromium heap snapshots and Firefox GC/CC logs):
windowlisteners kept the whole old UI (and its client) alive<For>snapshots offloatingElementskept unregistered entries (and their closures) aliveChanges:
Client.dispose()from stoat.js (sync teardown, clears collections)client().userreads during account switchesHow was this PR tested?
Screenshots & Screencasts (if appropriate)
Checklist:
Please declare, if any, LLM usage involved in creating this PR
No AI was used
main