Repository navigation
Conversation
…re Orca moved them Orca main moved validate-plugin-files.mjs and export-legacy-plugin-catalog.mjs into config/scripts/plugin-authoring/content-validation/, and plugin-theme-tokens.ts into src/renderer/src/app-shell/appearance/. Against a current Orca checkout, release-entry, check-catalog and the theme importer crashed with "Cannot find module". - scripts/orca-script.mjs returns an Orca script from its per-area folder or from config/scripts, and fails with "is not an Orca checkout" otherwise. release-entry, check-catalog, the importer and orca-schema.mjs's schema module loader all use it, so the layout rule lives in one place. - orca-schema.mjs loads each moved schema module, the terminal themes and now the theme tokens, through one local loadMoved that tries the new path first.
validate-catalog.yml pins ORCA_REF to current Orca main, which has the moved validator, legacy export and theme tokens, so CI runs the new paths.
Author
|
@nwparker tagging you since you wrote most of the importer and release scripts: this fixes the paths Orca moved, which currently break release-entry, check-catalog and the importer against a current Orca checkout. CI might need your approval to run from my fork 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Orca main moved a few files this repo loads, so
scripts/release-entry.mjs,scripts/check-catalog.mjsandtools/import-vscode-themeall crash against a current Orca checkout (the importer withCould not resolve ".../src/renderer/src/lib/plugin-theme-tokens.ts", the release scripts withCannot find module .../config/scripts/validate-plugin-files.mjs). CI didn't catch it cause it still validates against Orca 81ec82b, from before the move.scripts/orca-script.mjsfinds an Orca script in its new per-area folder or inconfig/scripts, and fails with "is not an Orca checkout" otherwise. The release scripts, the importer and the schema loader inorca-schema.mjsall use it, so the layout rule lives in one place.orca-schema.mjsloads the moved modules (the terminal themes and now the theme tokens) through oneloadMovedthat tries the new path first.I checked it against Orca main, 88880fc and the old 81ec82b layout: the importer tests pass,
release-entry.mjsprints "release entries: ok" and the importer converts a VS Code theme end to end.btw
plugins/orca-runner/README.mdstill points at the old validator path, I left it out cause a change there needs its own release entry.Execution profile (for anything above
data, say why it is needed)Not applicable: this changes only the repo's scripts, tools and CI, no plugin.