Repository navigation
Preserve mode identities and full-model Lamb shifts in EPR reports - #95
Open
davrens101 wants to merge 1 commit into
Open
davrens101 wants to merge 1 commit into
davrens101 wants to merge 1 commit into
Conversation
Contributor
Author
|
I cherry-picked all seven SQDMetal fixes (#91-97) onto their shared upstream base and they apply cleanly together. The existing focused tests give 14 passed, 21 subtests passed (19 source/dependency/SciPy warnings, not suppressed). I also ran the 15 ordered three-mode EPR selections, 18 single-qubit capacitance configurations, three two-qubit input forms, single- and multi-port linewidths, and absent optional files directly, and they all work. No new permanent tests for #95-97, and I did not run the full suite or an external EM solver. |
This was referenced Nov 4, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Selecting
modes_to_compare=[3,1]currently labels mode 1 as mode 3 and vice versa: the retained arrays stay in ascending order, but receive requested-order labels. Selecting fewer modes also changes their dressed frequencies because unreported modes are deleted before the Lamb-shift sum.Calculate the Hamiltonian quantities from all simulated modes, then select the requested rows and matrix columns from the output DataFrames. Both entry-point docstrings now describe the one-based reporting selection and full-mode Lamb shifts. Public signatures and return keys are unchanged.
Actual three-mode/two-junction CSV reproduction:
mode_3reports 4 GHz andmode_1reports 8 GHz for selection[3,1].Verified with actual imports and temporary CSV/config files, without mocks or an external solver. No permanent tests added, per contributor preference. Independent read-only AI review found no blocker. CPU-only; no full-suite or external EM-solver validation claimed.
Review and assistance
Human review: davrens101 confirmed reviewing the work live before submission. AI assistance was used for investigation, implementation and verification. No maintainer review or approval is claimed. Verification was CPU-only; no GPU validation is claimed.