Repository navigation
Preserve optimizer solutions and report the original constraint cost - #93
Open
davrens101 wants to merge 1 commit into
Open
davrens101 wants to merge 1 commit into
davrens101 wants to merge 1 commit into
Conversation
Contributor
Author
|
I cherry-picked the four independent SQDMetal fixes (#91-94) onto their shared upstream base and they apply cleanly together. Parser, LC, optimizer, transmon and the existing component geometry tests: 14 passed, 21 subtests passed. The optimizer/JSON run and a 61-state charge-basis Hamiltonian check also pass. With #94's corrected energy physics the floating original-target cost becomes 131.30895980700444 and still matches the independently calculated residual. CPU only, existing warnings not suppressed, no full suite or external EM solver. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Qubit design reporting aliases the SciPy solution vector and replaces optimization targets with derived physical quantities. All-fixed Xmon optimization can return a read-only vector and crash during this reporting step. Floating-transmon reporting mutates the vector before recomputing its objective, understating the residual against the original constraints; its returned cost is also a one-element set rather than a number.
Change
sol.fun) for reporting, without evaluating an altered vector.cost_error_%from floating-transmon optimization.No optimizer algorithm, objective, physical formula, public signature or Xmon return convention changes.
Verification
ValueError: assignment destination is read-only; floating-transmon reporting gives 48.73865330737892 instead of the independently calculated 140.26009493027976 percent, and returns a set.python -m pytest -q UnitTests/test_qubit_optimisation.py UnitTests/testBasicQiskitMetal.py: 4 passed. Existing initial-guess-outside-bounds SciPy warning and two dependency deprecation warnings remain; they are not suppressed.Review and assistance
Human review: davrens101 confirmed reviewing the work live before submission. AI assistance was used for investigation, implementation and verification. No maintainer review or approval is claimed. Verification was CPU-only; no GPU validation is claimed.