Skip to content

@relextm19/refactor color extraction - #857

Merged
relextm19 merged 2 commits into
mainfrom
@relextm19/refactor-color-extraction
Nov 9, 2026
Merged

relextm19 merged 2 commits into
mainfrom
@relextm19/refactor-color-extraction

Conversation

@relextm19

Copy link
Copy Markdown
Collaborator

Summary

The list of CSS named colors was duplicated in three places. Now there's one source of truth and:

  • Web imports the JSON directly in colorNormalizer.ts.
  • iOS and Android use generated files, produced by scripts/generate-css-colors.js (yarn generate:colors):
    • ios/extensions/CSSNamedColors.generated.h, included by ColorExtension.mm

To change a color: edit the JSON, run yarn generate:colors, and commit all three files.

Test Plan

Change the json file run yarn generate:colors from the repo root, then check that the committed files

Compatibility

OS Implemented
iOS ✅
Android ✅
Web ✅

Checklist

  • E2E tests are passing
  • Required E2E tests have been added (if applicable)

Copilot AI balanced review requested due to automatic review settings November 6, 2026 15:36

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.

@szydlovsky szydlovsky left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the change centralizing CSS named colors across web, iOS, and Android.

No open issues 🎉

Review effort: Balanced

@relextm19
relextm19 merged commit b7eb7be into main Nov 9, 2026
9 checks passed
@relextm19
relextm19 deleted the @relextm19/refactor-color-extraction branch November 9, 2026 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants