Repository navigation
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Unresolved critical flaws can overwrite another account’s data, lose or duplicate changes during synchronization, and exhaust server memory through unbounded patch-copy expansion.
6 open issues
Limit copy expansion during patch application · New Apply PATCH requests in a single transaction · New Clear the initial snapshot when resetting · New Prevent duplicate effects when retrying committed patches · New Ignore stale sync completions after account changes · New Upload migrated settings before sending patches · New
1 file not reviewed
pnpm-lock.yaml: Generated file
What changed in this PR
This PR moves user-data synchronization from repeated full-state uploads to an initial upload followed by JSON patches, updating both the Vue stores and the Genesis backend.
Changes:
- Route budget, year, and settings mutations through a shared patch queue.
- Add a Genesis PATCH endpoint, SDK support, dependencies, and backend tests.
- Adjust login feedback, logger formatting, and commit-message validation.
| File | Description |
|---|---|
src/utils/logger/logger.ts |
Add logger-specific colors and level labels. |
src/store/storage/useStorage.ts |
Manage initial uploads, queued patches, and retries. |
src/store/state/index.ts |
Route state updates and imports through patches. |
src/store/state/actions/year.actions.ts |
Convert year actions and undo operations to patches. |
src/store/state/actions/budgetGroup.actions.ts |
Convert budget-group actions to patches. |
src/store/state/actions/budget.actions.ts |
Convert budget actions and undo operations to patches. |
src/store/state/actions/action.types.ts |
Define readonly state and mutation interfaces. |
src/store/state/actions/action.helpers.ts |
Add path lookup and move-operation helpers. |
src/store/settings/index.ts |
Route settings changes through patches. |
src/store/genesis/genesis.sdk.ts |
Add JSON Patch types and client requests. |
src/app/pages/navigation/auth/LoginDialog.vue |
Hide the session warning during login requests. |
pnpm-lock.yaml |
Lock the frontend patch dependency. |
package.json |
Add rfc6902. |
genesis/routes/setup.go |
Register the PATCH endpoint. |
genesis/routes/data.go |
Apply patches and share request validation. |
genesis/routes/data_test.go |
Test patch operations, validation, and size limits. |
genesis/go.sum |
Record backend patch dependency checksums. |
genesis/go.mod |
Add the Go JSON Patch library. |
.husky/commit-msg |
Revise accepted commit types and add optional scopes. |
Review effort: Balanced
simonwep
force-pushed
the
data-patches
branch
from
November 4, 2026 17:47
e2774d3 to
b851051
Compare
add patch endpoint to sdk
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
With this PR the entire data-stack is pushed once to the server and json patches are used afterwards. It's much faster and efficient than updating the whole value for each key every time.
I made sure that:
chore: fix eslintcommits).