Repository navigation
Conversation
sahenjp
added a commit
that referenced
this pull request
Nov 6, 2026
The open retrieval, page-fetch and maintenance PRs conflict with the provider rollout now on main. This integration preserves their fixes and the current endpoint-review and MCP budget contracts. ## Changes - Integrate #103, #106, #107, #108, #109 and #110, with conflicts resolved against v0.29.0. - Keep local-source pagination and explicit selection, source weights, bounded index work and atomic index replacement. Apply the existing per-host diversity cap to merged local results while preserving single-source paging. - Carry validated explicit Accept-Language preferences through MCP, HTTP raw content, page caches and renderer resources. - Preserve source URLs, author links and supplied licences. Add scoped provider evidence and prevent a named entry from overriding a module restriction. - Fix the renderer race where a self-closing worker destroys its evaluation context before Playwright delivers its close event. - Retain explicit tokenizer budgets and document their counting scope and frozen-response measurements. - Resolve dependency and release-version conflicts while keeping the empty audit exception baseline. ## Validation - Rust all-target tests passed, 1106 successful and 4 ignored. Three require optional external services or browser setup, and one generates an offline benchmark artifact. - Clippy with warnings denied, fmt and diff checks passed. - Python suite passed, 63 tests. - Real Firefox renderer suite passed, 16 tests, including self-closing workers, delayed worker/fetch chains, broker failures and the shared deadline. - The dependency integration passed Rust 1.88 checks and cargo audit with zero vulnerabilities, unmaintained warnings or unsound warnings. - The latest head e478916 passed all 14 cross-platform CI checks. It includes the final observations and credit-limit report. - The earlier API-active runs reached hit@1 72/100 and hit@5 87–88/100 at 699–853 ms median. The final integration evaluation encountered HTTP 402 / NO_MORE_CREDITS. Its first API run reached 69/84, Standard reached 54/68, and the second API run with the exhausted account reached 50/64. All responses and per-source states are retained in bench/results/issue-resolution-2026-11-06/. The independent Japanese compiler corpus remains difficult, with poor reference-page retrieval. Its observations and cache conditions remain published. The final Japanese run also encountered the exhausted account. API billing requires selecting the API profile and supplying the operator's key. ## Remaining merge gate Issue #104 requires verification with available Exa credits or another reviewed source configuration. This PR remains Draft under the requested sequence of resolving all issues before merge. The operator has been asked to restore the provider budget or select an available reviewed source. The measurements and blocking response are documented in docs/ISSUE-RESOLUTION-2026-11-06.md. Fixes #40. Fixes #41. Fixes #60. Fixes #63. Fixes #79. Related to #104 and #16. Draft #37 was closed after reviewing its unresolved change request and obsolete page-fetch path. Issue #16's remaining default Bing enablement requirement was retired under the provider policy. Implementation and review were AI-assisted. --------- Co-authored-by: Ana <269872094+TKY-27@users.noreply.github.com> Co-authored-by: Sahen <262773687+sahenjp@users.noreply.github.com>
Owner
|
内容は #113 に統合してマージ済みです。本PRはクローズします。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The real Firefox fixture intermittently loses worker-produced DOM content on Windows. This was observed on unchanged renderer code in PR #103 and again in #106 (Windows job 127290092842, assertion at
test.cjs:78). The helper takes its snapshot immediately after Playwright's page network-idle event, without accounting for worker startup and the complete broker/fulfillment lifecycle.Changes
route.fulfillorroute.abort, then apply the existing 500 ms quiet period.The guarantee remains a bounded quiet period after observed activity. Arbitrary later timers or full application completion are not inferred.
Validation
Actual Firefox verification is pending CI. This environment rejects Firefox's sandbox user-namespace setup with
uid_map EPERM; its controls were not relaxed. Cross-platform Firefox jobs must establish the fix on Windows, Linux and macOS. This PR does not claim those checks have already passed.This is an independent prerequisite for reliable renderer CI on the other open changes. Implementation and tests were AI-assisted and reviewed before submission.