Repository navigation
Keep missing Type G dates empty - #242
Merged
Merged
Conversation
lategoodbye
requested changes
Oct 16, 2026
|
|
||
| EXTRA_DIST = test-frames/issue-123.hex \ | ||
| test-frames/issue-123.xml \ | ||
| test-frames/issue-123.norm.xml |
Collaborator
There was a problem hiding this comment.
Could you please drop the test program and just keep the hex, xml and norm.xml?
Changes to this file are not necessary, the xml files are done by generate-xml.sh
| ACLOCAL_AMFLAGS = -Werror -I m4 | ||
|
|
||
| check-local: | ||
| $(MAKE) -C test check |
Collaborator
There was a problem hiding this comment.
Please drop this, too
Collaborator
|
Thanks for fixing this old issue. Could please move the first paragraph of the pull request into the commit message of the first commit? |
The frame in rscada#123 contains `FF FF` for a missing Type G date. Both XML modes currently show `2127-15-31`. Return an empty value in both date conversion paths and keep the record metadata.
radixun
force-pushed
the
fix/type-g-missing-date
branch
from
October 17, 2026 10:27
84cc9a1 to
e686cd6
Compare
Contributor
Author
|
Removed the C test program and both Please review the updated PR when you have time. |
Collaborator
|
Thanks |
lategoodbye
approved these changes
Oct 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Return an empty value for a missing Type G date in both XML modes. Add the frame from #123 and its expected XML files.
Validation on Linux with GCC and UBSan:
generate-xml.shchecks all 78 frames.Fixes #123.