Repository navigation
Conversation
The kernel skips a syscall with a negative number after its seccomp stop, and rr records the syscall's entry at the next record_step. Allowing a switch in between let other threads' events be recorded first, even if they depended on what the thread did before the syscall, so replay could diverge. Keep switching prevented there, as for seccomp-induced errno and trap results. Test: negative_syscall_switch Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Collaborator
|
Looks good but needs merge conflicts to be resolved |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The kernel skips a syscall with a negative number after its seccomp stop, and rr records the syscall's entry at the next record_step. Allowing a switch in between let other threads' events be recorded first, even if they depended on what the thread did before the syscall, so replay could diverge. Keep switching prevented there, as for seccomp-induced errno and trap results.
Test: negative_syscall_switch