Repository navigation
Handle a killed task's exit before other tasks' events - #4129
Merged
rocallahan merged 1 commit intoOct 20, 2026
Merged
Conversation
When a SIGKILL took the running task out of a stop before rr read it, rr switched to other tasks (since 024064f) and recorded their exits before the killed task's last execution, so replay could diverge. Wait for the killed task's PTRACE_EVENT_EXIT stop and handle it first, except where that wait could deadlock. Test: killed_task_exit_order Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Encountered/debugged/test/patch by AI]
When a SIGKILL took the running task out of a stop before rr read it, rr switched to other tasks (since 024064f) and recorded their exits before the killed task's last execution, so replay could diverge. Wait for the killed task's PTRACE_EVENT_EXIT stop and handle it first, except where that wait could deadlock.
Test: killed_task_exit_order